[Enhancement] Physical Keyboard support - When typing, automatically start filtering app list

dessalines commented 5 months ago

Checklist

[X] I will make sure to have the issue written in English with an English title.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have already checked the WIKI pages and made sure that the feature isn't already exist.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I optionally donated to support the mLauncher mission.

Feature description

My main machine is an android tablet, with a physical keyboard. One feature from KISS / monocles launcer that I really miss, is that as soon as I type a letter on the physical keyboard, it starts filtering.

In mLauncher, I have to swipe up to get to the app list first, then I can start typing letters. Keys typed before that are ignored.

I'd love for keyboard presses to immediately start filtering, rather than having to swipe down first.

Additional information

NA

Terms and Conditions

[X] I have read all the rules above and filled in the requiered fields to the best of my ability.
[X] I accept that if I fail to follow the rules listed above that i will be blocked from interactions with this project.

Gitbot-Actions commented 5 months ago

👋 Thanks for reporting!

We will get back to you soon about this issue.

HeCodes2Much commented 5 months ago

Take a look at #474 this is already some what requested

HeCodes2Much commented 5 months ago

@dessalines if you are willing to do testing ill gladly take a look into your request a bit more along side #474

dessalines commented 5 months ago

Sure, just let me know branches or builds to try out.

HeCodes2Much commented 5 months ago

@flobere an @dessalines could you test this for me and give me feed back?

app.mlauncher_v1.5.9-Debug.zip

dessalines commented 5 months ago

Typing with physical keyboard right away didn't work, still needed to pull up to the app list. Enabled auto_show_keyboard and behavior was the same.

HeCodes2Much commented 5 months ago

Does the menu key work for you to bring up the apps?

Once I work that out I can enable it for any letter.

HeCodes2Much commented 5 months ago

@dessalines the latest release the menu key should be working if you want i can add other keys to allow that menu to show when pressed.

if i was to add all letters then it would open when clicking a letter but you would need to click it twice to have it start typing as i can't seem to find a way to open and type first letter

dessalines commented 5 months ago

I don't have the menu key on my tablet, only full screen gestures, with a physical keyboard connected.

flobere commented 5 months ago

If your keyboard has one, it should be near your right ctl. Easy to miss. When I tried the app with a keyboard, ctl+esc also worked (replicates the android menu key).

Would something like this or a meta key press be efficient enough? Or are you hoping to filter all installed apps from homescreen without an extra keypress?

dessalines commented 5 months ago

I don't see why an extra keypress is necessary for a physical keyboard. KISS launcher / monocles can start filtering immediately on any keypress.

HeCodes2Much commented 5 months ago

KISS Launcher is a bad example as it does not even work the same. it has the search from the main fragment not as a 2nd fragment where as mLauncher you swipe to get into a different fragment then search that not just searching from the home fragment.
Monocles being a fork of KISS this is the same issue they don't use a different fragment for the appList and the Search you just search and view apps in the same fragment
i would need to have the key presses launch to the allApps fragment then search in that fragment ill have a look to see if i can farward from home to appApps and have it auto input the first letter after you enter the applist

HeCodes2Much commented 5 months ago

@dessalines and @flobere do you both want to test this please?

app.mlauncher_v1.6.0-Debug.zip

flobere commented 5 months ago

Works for me on android 12 with a keyboard plugged in. Admittedly haven't tested very thoroughly, I don't use a keyboard. makes the already existing search filtering really useful imo.

Only thing i'd suggest from a user perspective is maybe being able to escape the app drawer/ filtered app list with the Esc key

EDIT the only unexpected behaviour: opening app drawer with menu key press pre-fills the app search with "null". opening the app drawer with swipe gesture has the usual empty field.

dessalines commented 5 months ago

@HeCodes2Much That's mostly working, nice!

Only thing i'd suggest from a user perspective is maybe being able to escape the app drawer/ filtered app list with the Esc key

Agreed, that'd be nice to have.

HeCodes2Much commented 5 months ago

Only thing i'd suggest from a user perspective is maybe being able to escape the app drawer/ filtered app list with the Esc key

Does this not already happen. it does when testing on android studio. with a keyboard.

1x ESC closes keybard 2x ESC goes to homescreen

EDIT the only unexpected behaviour: opening app drawer with menu key press pre-fills the app search with "null". opening the app drawer with swipe gesture has the usual empty field.

ya sorry i forgot to check for null ill fix that before release

dessalines commented 5 months ago

With my physical keyboard at least, the escape key doesn't do anything. It could be a case of the difference between the escape keycode, and the action.

HeCodes2Much commented 5 months ago

With my physical keyboard at least, the escape key doesn't do anything. It could be a case of the difference between the escape keycode, and the action.

maybe ill have to look into why maybe ESC on android studio is the same as pressing the back button?

dessalines commented 5 months ago

I could see why it might be like that, but you might just need to use the https://developer.android.com/reference/android/view/KeyEvent.html#KEYCODE_ESCAPE keyEvent.

HeCodes2Much commented 5 months ago

@dessalines does this work now? i think i got it working but im not 100% sure

app.mlauncher_v1.6.0-Debug.zip

dessalines commented 5 months ago

Yup that worked! Thx.

HeCodes2Much commented 5 months ago

Yup that worked! Thx.

Sweet just need to commit it then i will be doing a release soon.

DroidWorksStudio / mLauncher