search

Droidcon-Boston / conference-app-android

Official conference app for Droidcon Boston
http://www.droidcon-boston.com/
Apache License 2.0
98 stars 25 forks source link

Make MainActivity singleTop Fixes #185 #193

Closed n8ebel closed 5 years ago

n8ebel commented 5 years ago

https://github.com/Droidcon-Boston/conference-app-android/issues/185

This was to avoid putting 2 activites into the Recents stack when the app is started Before this change, when the app started, and the user viewed the Recents list there would be 2 tasks listed

Using singleTop here aims to avoid a new task for the MainActivity while also avoiding creating multiple instances of MainActivity in respsone to push notifications which is what the previous SingleTask launch mode was aiming to achieve

fetching commented 5 years ago

👍

AdamMc331 commented 5 years ago

Looks good to me. Are we free to merge this? I saw in the issue that we wanted to validate with notifications too. Not sure if we should hold up until then or not.