Droidcon-Boston / conference-app-android

Official conference app for Droidcon Boston
http://www.droidcon-boston.com/
Apache License 2.0
98 stars 25 forks source link

Issue #164: Try to fix app crash possibly related to animation #196

Closed fetching closed 5 years ago

fetching commented 5 years ago

I noticed that in my build the random crash happens on line 243 inside addListener(). I also noticed that when the app crashes it appears random: I'll be using the app, changing screens and scrolling up and down and suddenly it crashes.

I wondered if the issue is the listener is leaking and needs to be canceled when the view is destroyed:

https://developer.android.com/reference/android/animation/AnimatorSet.html#cancel()

I don't know animations but I tried this fix and used the app a while and it didn't crash and the dancing Android is working. Perhaps someone can review if this fix would be appropriate?