search

DroidsOnRoids / SwiftCarousel

Lightweight, written natively in Swift, circular UIScrollView.
http://www.thedroidsonroids.com/blog/ios/circular-scroll-view-swiftcarousel/
MIT License
144 stars 43 forks source link

Distinguishing between "scrolled to" and "tapped" #23

Closed frranck closed 8 years ago

frranck commented 8 years ago

Hi Lukasz, Is there a way to distinguish between the situation where an item has been scrolled to, and the situation where an item has been tapped ? I seems selectItem doesn't inform on that that.

sunshinejr commented 8 years ago

Hey @frranck, currently not, but it could be added as well. The only question is if we should send 2 notifications, one when you tap, and then after X seconds the selected one? What's your opinion? Cheers! 🎉

frranck commented 8 years ago

@sunshinejr Not sure, I would definitely need a flag with the select to inform me it's the result of a tap, and If a card is already selected, I would also need to be able to know if the user tapped it afterwards.

I guess we would also need to to authorize taps, while scrolling in the cards using shouldRecognizeSimultaneouslyWithGestureRecognizer

sunshinejr commented 8 years ago

Hmm, right. We should add the property for protocol method then. Second method also seems cool. Would you be up for making PR, @frranck? :rocket:

frranck commented 8 years ago

@sunshinejr OK!

frranck commented 8 years ago

@sunshinejr If I tap around while scrolling, the scroll "jumps around suddenly" did you notice that ? What is causing this ? (You can see that in the examples)

sunshinejr commented 8 years ago

Hmm, didn't catch that one. I'm kinda busy today, so I can't really check what is happening.. Will make sure to do it ASAP tho. We could add this as another issue rather than discuss it here as well. Thanks tho! 👏

sunshinejr commented 8 years ago

This one is already on CocoaPods, I think we can close it for now.