DroidsOnRoids / bitrise-step-sonarqube-scanner

Step for running SonarQube Scanner CLI
MIT License
6 stars 19 forks source link

Fix input properties append when there is no newline at the end of the existing file #14

Closed RomuloVitoi closed 4 years ago

RomuloVitoi commented 4 years ago

There's an issue that happens If you have a sonar-project.properties file without a newline at the end and provide an input for scanner_properties, the scanner_properties value is appended along with the value of the last line, e.g:

sonar-project.properties:

foo=bar

scanner_properties:

bar=baz

the resulting file will look like:

foo=barbar=baz

I'm adding this empty echo just to add a newline to the existing file before appending the input to avoid this issue.

RomuloVitoi commented 4 years ago

FYI @koral--