search

DroidsOnRoids / bitrise-step-sonarqube-scanner

Step for running SonarQube Scanner CLI
MIT License
6 stars 19 forks source link

Handles "latest" special value for scanner_version #20

Closed DayS closed 3 years ago

DayS commented 3 years ago

Instead of updating the default version for every release of the Scanner, this PR handle a latest value for the scanner_version input.

In this case, the script will use the Github API to fetch the last public release of Sonnar-scanner from the official repository.

The use can still use a specific version if needed.

koral-- commented 3 years ago

Adding the support for latest version is perfectly fine. However, changing the default value to latest shouldn't be done. Workflows which have it unset will become not reproducible after updating the step version.

DayS commented 3 years ago

It makes sense, I'll update PR to rollback to the fixed version 4.3.0.2102 as default.

koral-- commented 3 years ago

Thanks, I'll fix CI ASAP.

DayS commented 3 years ago

Perfect. I'm looking forward the new version on Bitrise :)