search

Drombler / drombler-fx

Drombler FX - the modular application framework for JavaFX.
https://www.drombler.org/drombler-fx
Other
60 stars 8 forks source link

Set the systemMenuBar property to true by default [sf#64] #65

Closed puce77 closed 9 years ago

puce77 commented 9 years ago

Reported by puce on 2014-12-22 12:23 UTC The current plan was to set the systemMenuBar property to true by default. Unfortunately, I now realized that the implementation is completely wrong, as you can see here: http://sourceforge.net/p/drombler/drombler-fx/ci/drombler-fx-0.5/tree/drombler-fx-core-application/src/main/java/org/drombler/fx/core/application/impl/ApplicationPane.java

Instead of setting the systemMenuBar property the useSystemMenuBarProperty() method gets called.

As I don't have a Mac at hand to test the behavior and since JavaFX differs from Swing in that way that with JavaFX you have to explicitly add the MenuBar to some LayoutPane while with Swing, the jMenuBar is a property of JFrame, I cannot really test what it will look like if the property is set to true.

From the documentation there should be no effect at least, when there is no system menu bar (this is something I can test, of course): http://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/MenuBar.html#useSystemMenuBarProperty

puce77 commented 9 years ago

Commented by puce on 2014-12-22 12:24 UTC Related: [#61]

puce77 commented 9 years ago

Updated by puce on 2014-12-22 12:35 UTC

puce77 commented 9 years ago

Commented by puce on 2014-12-22 12:35 UTC This issue has been fixed. Please test it as I don't have a Mac at hand.

puce77 commented 9 years ago

Commented by hardcoder on 2015-01-02 15:57 UTC Tested. Works.

puce77 commented 9 years ago

Updated by puce on 2015-01-15 16:48 UTC