Dronecode / camera-manager

Camera Manager for interfacing cameras with the Dronecode platform
https://camera-manager.dronecode.org/en/
Apache License 2.0
63 stars 51 forks source link

Need vidstream params config section #182

Open seanrowens opened 6 years ago

seanrowens commented 6 years ago

The documentation on config files is a tad unclear, so maybe I'm doing this wrong. I tried to set frame rate to a 5 and image width/height to 640x480, but when I stream the video I'm still seeing 1920x1080 images at 30FPS. Someone on slack said those parameters only apply to vidcap and not to streaming, and suggested that I file this issue.

hamishwillee commented 6 years ago

I suspect the vidcap is for video saving, not video streaming. I don't believe there are parameters to control the RTSP streaming but @lbegani will know for sure.

Lalit, when this is confirmed, I'll tidy the docs for vidcap to make this clear.

seanrowens commented 6 years ago

Thank you.

On Wed, Sep 5, 2018 at 6:18 PM Hamish Willee notifications@github.com wrote:

I suspect the vidcap is for video saving, not video streaming. I don't believe there are parameters to control the RTSP streaming but @lbegani https://github.com/lbegani will know for sure.

Lalit, when this is confirmed, I'll tidy the docs for vidcap to make this clear.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Dronecode/camera-manager/issues/182#issuecomment-418899884, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGek6cWJfxej3NXmz7lIxgDp1MR60bIks5uYE2rgaJpZM4WbVik .

lbegani commented 6 years ago

I suspect the vidcap is for video saving, not video streaming. I don't believe there are parameters to control the RTSP streaming but @lbegani will know for sure.

Lalit, when this is confirmed, I'll tidy the docs for vidcap to make this clear.

@hamishwillee That's right. vidcap is to configure the output of video capture. For video streaming, the fps and bps parameters are not configurable. Need to add a similar section like vidstream in conf file to take input the configurable parameters of video streaming.

hamishwillee commented 6 years ago

Thanks @lbegani . Docs fixed in https://github.com/Dronecode/camera-manager-docs/commit/6b0167934a16c7ead9d7e069db43f6acfc007723

Let's leave this open to track vidstream - I'll rename to make it clear.