DropSnorz / OwlPlug

Audio plugin manager. Small tool to manage VST / AU / LV2 plugins on Windows, MacOS and Linux.
https://owlplug.com
GNU General Public License v3.0
287 stars 11 forks source link

Download Projucer from trustworthy source #98

Closed kmturley closed 3 years ago

kmturley commented 3 years ago

In your script Projucer is downloaded from an external source (https://projucer.rabien.com): https://github.com/DropSnorz/OwlPlug/blob/45e6e3b6c5d17b6073dfe1a8b9a88ad5bc20f278/build/download-projucer.sh#L15

It's seems possible to download Projucer from the Github JUCE library releases directly:

curl -L https://github.com/juce-framework/JUCE/releases/download/6.0.8/juce-6.0.8-osx.zip --output jucesdk.zip
unzip jucesdk.zip
./JUCE/Projucer --resave example.jucer

https://github.com/maxmarsc/raciderry/blob/2372764e970ef62a3df6b703cf59c53fb37d0cac/.github/workflows/unittests.yml#L21

This reduces the dependency on an external source and may even provide performance benefits!

DropSnorz commented 3 years ago

You are right, thank you for pointing out this !

DropSnorz commented 3 years ago

Done, OwlPlug binaries are built with the official JUCE release. 👌