Drops-of-Diamond / diamond_drops

WIP on sharding and Ethereum 2.0 with enshrined-in-consensus data availability and Rust: a fast, safe, concurrent and practical programming language
The Unlicense
57 stars 14 forks source link

Running in "both" mode only processes the "proposer" thread but not the "collator" thread #16

Closed ltfschoen closed 6 years ago

ltfschoen commented 6 years ago

In the 'collator' branch when I run in "Both" Mode, it only shows it processing the "Proposer" thread being joined, but not also the Collator thread. It doesn’t appear to process the Collator part on Line 70

ChosunOne commented 6 years ago

join is a blocking operation, it waits for the thread to end. These last two lines only exist to make sure both threads are running. The threads start running at the spawn command. It isn't necessary for Line 70 to be run, only that main doesn't exit before both threads have finished.