search

Drops-of-Diamond / diamond_drops

WIP on sharding and Ethereum 2.0 with enshrined-in-consensus data availability and Rust: a fast, safe, concurrent and practical programming language
The Unlicense
57 stars 14 forks source link

License maintainer #40

Open jamesray1 opened 6 years ago

jamesray1 commented 6 years ago

This updates the license header for previous commits to match a template, as well as checking future commits to make sure that the license header matches with the template, but there are merge conflicts to fix. However, it doesn't work properly.

Alternatively, with research an easier alternative could possibly be found.

jamesray1 commented 6 years ago

I think those changes must have been included by mistake, I'll fix that. I left out @ChosunOne's last name deliberately because I think he prefers to retain a level of anonymity.

jamesray1 commented 6 years ago

I wish you would talk to me before going and making changes, there were reasons why I had the first line like "AUTHORS, James Ray, Josiah @ChosunOne, and Luke Schoen". When I was making these changes, the AUTHORS which occurs twice in the license header was being replaced. However the author of the repo recognized that was an issue and may have fixed that since then.

jamesray1 commented 6 years ago

I will wait for a confirmation from @ChosunOne for his preference about his name and the license header before making these changes in another PR with just the changes for the license maintainer, or update this PR accordingly.

jamesray1 commented 6 years ago

I'm going to assume that @ChosunOne prefers not to add his last name, if he prefers otherwise he can change that later.

There have been no changes to the license-maintainer repo, so we will need to use the format that I had originally, at least until the repo is fixed. https://github.com/NitorCreations/license-maintainer/issues/9#issuecomment-382611807

jamesray1 commented 6 years ago

I'm going to assume that @ChosunOne prefers not to add his last name, if he prefers otherwise he can change that later.

There have been no changes to the license-maintainer repo, so we will need to use the format that I had originally, at least until the repo is fixed.

jamesray1 commented 6 years ago

I'm making another PR, but am just trying to make hacky fixes to get it to "work" again.

jamesray1 commented 6 years ago

I'm making modifications to https://github.com/NitorCreations/license-maintainer without references to year or authors as they aren't needed for the Unlicense. Further updates will be posted at https://github.com/NitorCreations/license-maintainer/issues/9 and in a new PR.

jamesray1 commented 6 years ago

See https://github.com/paritytech/parity/pull/8666 for inspiration.