Open jamesray1 opened 6 years ago
@samparsky, interested? On second thought, as noted above, this task needs #78 first which @tcsiwula is working on, so it would be best if he handled this as well.
@jamesray1 Yeah sure but if @tcsiwula wants to handle it, okay
Requires work on a bintrie and #78.
Is your feature request related to a problem? Please describe.
geth-sharding had results (see the below link) of 80000 ns/op roundtrip serializing/deserializing a blob to a collation body and back for their benchmark, while other results ranged from 100th to less than half of this. Note that we will need to do #78 first before this is done, so this might be a task suited for @tcsiwula when done with #78, if he's up for it?
Describe the solution you'd like
Write bench tests and compare with other results e.g. in the geth-sharding issue below, to decide whether further optimizations are needed. Writing bench tests are a nightly feature, see https://doc.rust-lang.org/stable/unstable-book/library-features/test.html FMI. If results indicate a large improvement is needed, e.g. worse than XML, then fixing this would be a more immediate priority, otherwise it could be postponed until e.g. post-production.
Describe alternatives you've considered
Additional context https://github.com/prysmaticlabs/geth-sharding/issues/139
Cute Animal Picture