search

DroptuneHQ / droptune-og

New music notifications for Spotify & Apple Music. Follow your favorite artists so you never miss a beat.
https://droptune.co
MIT License
93 stars 16 forks source link

Spotify embed is not embedded #64

Closed tnorthcutt closed 6 years ago

tnorthcutt commented 6 years ago

This morning I noticed that album views do not seem to have a Spotify embed, whereas I recall them having that the list time I used Droptune.

I also noticed a js error in the devtools console; not sure if it's related:

image

Should there be a Spotify embed on this page? If so, is there anything I can do to help debug this further?

Shpigford commented 6 years ago

@tnorthcutt Give it a look now. There's a few things it tries to do to determine which player to show you and so I adjusted that.

tnorthcutt commented 6 years ago

@Shpigford Yep, working better now, thanks!

I'm curious: why default to Apple Music embeds (at least that's how I'm reading the source; maybe I'm wrong – I don't use Ruby much).

Edit: I guess the obvious answer is "gotta pick one"?

Shpigford commented 6 years ago

@tnorthcutt Well what I made it do now is say...

If user has connected Apple Music, show that player Else if user has connected Spotify, show that player Else show Apple Music

When it makes sense to, I try to default to the Apple Music player as it's just a much better player. Doesn't have as many in-browser issues, lets you add to your library right from the player, etc. Just a better experience.

That being said, if a user users Spotify, then it should now default to that player first over Apple Music, when available.

tnorthcutt commented 6 years ago

Roger that. Thanks for explaining the reasoning!