search

DrupalSecurityTeam / drupalpcicompliance

Official github repo for the Drupal PCI compliance white paper.
http://drupalpcicompliance.org
Other
55 stars 15 forks source link

Fix grammar and sentence structure. #33

Closed arknoll closed 10 years ago

rickmanelius commented 10 years ago

Hi @arknoll. Thank you very much! Clearly a few grammar/sentence errors went through despite the number of reviews from multiple people. There is one open TODO for me and there is one pushback item (I'd like to keep reference 9, which eliminates the need for the citation renumbering), but most can and will be committed as is. Keeping this PR open for now...

rickmanelius commented 10 years ago

Hi @arknoll two more things:

  1. Please add yourself to the list of reviewers (alphabetical order by last name). You're feedback was thorough and will make this a better paper. Thank you.
  2. Given your background as lawyer, if you have any opinion on the the following issue https://github.com/rickmanelius/drupalpcicompliance/issues/30, by all means let us know. I've discussed directly with a QSA and read other interpretations by other QSAs. I fall into the camp where direct post is clearly SAQ A-EP and HPP is (by strict definition of SAQ A, which has precedence over the suppleemnt document) also SAQ A-EP. iFrame is in a gray area, where one can interpret either way. I know this request/question is out of scope of this pull request (which is addressing grammar and sentence structure), but I thought it wouldn't hurt to ask!

-Rick

rickmanelius commented 10 years ago

I think I have a response ready for issue #30 (and it will require a change to the paper in version 1.2). Otherwise, if the agreed upon changes are added, I'll get this merged in. And if you're out of time, I can simply apply them on top of this PR and get it in. Thanks!

rickmanelius commented 10 years ago

Hey @arknoll. I'll add onto your PR to make the necessary tweaks and then I'll get this merged in. Thanks!