DrupalStand / drupal-dev-docker

An opinionated Drupal development environment based on Docker.
GNU General Public License v2.0
22 stars 19 forks source link

Final Changes for 2.0 #18

Closed smfsh closed 6 years ago

smfsh commented 6 years ago

COPY webroot /var/www/webroot

This needs to be re-evaluated. When dockerfiles are poked to determine if a rebuild is necessary, as is the case with make init and make update, this line causes Docker to rebuild the images any time the environment is new. While this might seem like the preferred behavior, it adds a lot of time to the build process because docker doesn't use its cached images.

Additionally, once these files are written, this image becomes stale until another rebuild. If a user builds their environment on Monday, works on it through Friday without a make init or make update, when they do a make export-prod they will get Monday's code. Beyond this, the code we're copying in here from the webroot isn't enough to satisfy the installation as we are not copying in the config directory which would be necessary for this site to function on its own.