search

Drutol / CrossHMI

Reactive HMI Android application example
2 stars 0 forks source link

DataManagementSetup implementation should be independent #24

Open mpostol opened 3 years ago

mpostol commented 3 years ago

From the description, I can guess that the project provides two independent implementations of the DataRepository, According to the ReferenceApplication example and the architecture presented in https://commsvr.gitbook.io/ooi/reactive-communication/semanticdata#reactive-networking-application-architecture both need independent implementation of the DataManagementSetup. It promotes separation of concerns and reusability. Unfortunately, I can find only one implementation of this class, namely NetworkEventsManager.

It must be recognized as a data error, so some comments are required.

Drutol commented 3 years ago

That's true, I acknowledge that it should be separate, yet I have run into a bit of trouble which I have described here: https://github.com/mpostol/OPC-UA-OOI/issues/468

mpostol commented 3 years ago

Not sure if adding abstract may be recognized as a real relief. Anyway, it is done. I have also improved documentation in this respect.