Some stuff in the UWP version

[Guerra24]

New report will be added as a reply to this issue. Please do not close this issue. UWP edition of #121.

Icons:

• 🐞 Bug - It doesn't do what it's supposed to do, required to fix (feature issues, crashes)
• 🐝 Bee - I want it to look better, not required to fix (ui, animation, etc)
• 🍄 Mushroom - Feature Request/Suggestion
• 💙 Blue Heart - I like it! General Feedback

Feel free to edit.

---

• 🐞 Typo in "sort values".
  • ✔️ Fixed
• 🐝 Highlight is way too transparent.
  • ✔️ Fixed
• 🍄 Move the back arrow to the window frame.
  • ✔️ Fixed
• 🐝 Images in articles should be cropped or scaled instead of stretched (it looks bad).
  • ✔️ Fixed
• 🐝 Bottom bar position; left is how looks now, right is how it should be. Image
  • ✔️ Fixed
• 🐝 The bottom bar changes color in the "Images" view.
  • ✔️ Fixed
• 🐞 Going into "Anime recommendations" crashes the app (Fix ASAP).
  • ✔️ Fixed
• 🍄 Make the Title Bar use the accent color, only when the window is active.
  • ✔️ Use acrylic
• 🐝 Scrollbar arrows still appear even if the list does not exceed the max size. Vid. This is in the "History" view.
  • ✔️ Fixed
• 🐝 With some accent colors the highlight makes the text impossible to read.
• 🐝 Scrollbar should stick to the window border. Now, how it should
  • ✔️ Fixed
• 🐝 Anime images (right side) should be cropped or scaled instead of stretched (it looks bad).
  • ✔️ Fixed
• 🐝 Calendar highlight doesn't mach and the icon doesn't move with the background. Video
  • Well, I see why.
• 🐝 Closing the settings doesn't restore to the previous selected item in the hamburger menu. Video
• 🐞 Clicking an item multiple times will reload the view even if it is already loaded. Video
• 🐝 Drag to increase/decrease uses all available mouse buttons, some of them (middle click or custom) doesn't trigger the click animation.
  • UWP Bug...
• 🐞 Missing delete button when adding new anime to list. Video
• 🐞 The "clear image cache" is ultra slow and gets cancelled when the app is closed.
• 🍄 Use the entire button for the date selector. Video
• 🐞 Season selector partially broken. Video
• 🐞 Character name with special "symbols". Image
• 🐞 Forum posts broke. Image
  • ✔️ Fixed
• 🐝 Why not integrate the top area (hamburger button, list name and anime name) into the titlebar?
  • ✔️ Implemented.

[Drutol]

Are you planning to blurify things?

[Guerra24]

Not really, do some minor maintenance. Fix a small typo that I can't unsee and check some stuff that doesn't work right.

[Guerra24]

More problems... I'm unable to launch it from VS both in Debug and Release mode, it gets stuck on splash forever, no error, nothing.

EDIT: Temporary workaround by deploying the app so I can test it, it will be slow and painful but is the only way ATM.

[Drutol]

Hmm what version of Microsoft.NETCore.UniversalWindowsPlatform nuget are you using?

[Guerra24]

😶 😐

[Guerra24]

What do you think?

There is reveal in a lot of new places (I mean, A LOT). Switched to Acrylic blur for the header, increased image blur with a slightly darker color.

So....

This change requires the UWP Shared code to use FCU SDK, I tried to use conditional Xaml but it requires CU SDK so...

Extra

Where do you set the title bar color? (This is for the caption buttons background color). Calendar is broke (this is since the latest store update). Comp. view header text is also broke (this too).

EDIT: Guerra24/MALClient@2a33841874851e6b6b3a77552854521898826e29

[Drutol]

Wow, great job! Sorry that you had to go though this code ^^

I feel like the upper bar should be darker because now it's just "melting" with everything else. https://github.com/Drutol/MALClient/blob/master/MALClient.Dekstop/App.xaml.cs#L190

I'll try to find some time today to fix airing stuff.

[Drutol]

Feel free to submit pull request :)

[Guerra24]

The entire app header (Title bar included)?

Okay 😃

[Drutol]

Probably? Depends on how it looks ^^

[Guerra24]

This is how it looks.

EDIT: Hamburger menu with separators of the same color and the bottom grid transparent.

[Drutol]

Uppershadow looks nicer in my opinion.

Nice accent:

[Guerra24]

😂 I would prefer black but it can't be set so 🤷‍♂️

I've tried to increase the Shared project min sdk to FCU but it complains about it no begin compatible with 10586, it needs that because I've used acrylic on the list elements, it works but I don't know if the store would accept that.

[Drutol]

I remember having some issues with that too. In the end I didn't increase it ^^ What matters most for the store is main project's configuration so it shouldn't complain.

[Guerra24]

~Did you change something in the BGTasks? Now these projects refuse to compile~

😐 Cloned again the project and it worked.... wtf with vs...

[Drutol]

[Guerra24]

Is there a way to style scrollbars? I've found a way to fix the ones that are behind acrylic by adding margin to top and bottom of the scrollbar.

[Drutol]

If I were you I wouldn't touch them. It's just pain. At least they were 1,5y ago.

[Guerra24]

It was NOT really hard, just added this: Here And...

EDIT: Moved some elements to the titlebar.

EDIT2: Moved search to titlebar.

I will create a PR once I get all the header stuff done.

[Guerra24]

Finally completed header integration into title bar. It frees up some space in the list and creates a 3-column-view on the entire window.

EDIT: I completely forgot about the Load all details pop-up, it works but the grid gets placed at the bottom and doesn't update.

[Guerra24]

TL;DR Reworked again the UI.

[Guerra24]

Hey! I'm back after a month (or two) of inactivity. My PC's PSU broke and took a while to get a new one, I'm going to continue working on this on my free time but meanwhile I got a small maintenance PR.

[Drutol]

Hello! Thanks!

[Guerra24]

Got mobile fully working again, the PR is ready and both versions are OK to release (if nothing broke (I hope no)).

EDIT: HOLD ON, connected animations might have broke when I was fixing Mobile compilation, once I wake up I will fix it.

[Drutol]

Hehe, hmm... I haven't update mobile in ages... might be good idea ^^

[Guerra24]

It seems to have been fixed on its own... Feel free to merge.

[Guerra24]

I'm gonna change the target SDK to April Update (17134), are you OK with that? Also, why does Win10 Desktop notifications only show There are new notifications message instead of Win10 Mobile where it actually tells you what it is?

[Drutol]

No clue, I didn't notice There are new notifications yet. (I'm on April's update)

Go ahead with new SDK, I'm fighting with MSFT about certification right now...

[Guerra24]

~(Some) Promotional Videos broke, android and uwp affected.~ Uh, it fixed on it's own 🤔🤔🤔

Btw, because I'm gonna continue working here and to make this more easy for both, would you give me write access to the repo? So I don't have to make PRs for single commits or similar stuff.

[Drutol]

Well, I don't mind. The master will be kept protected though :)

[Guerra24]

Did some labels renames, examples: Android -> Platform: Android, Info -> Type: Info. And new lablels: Platform: UWP, Status: Cannot Reproduce, Type: Bug, Type: Question, etc.

Also write an issue template, what do you think?