search

Drutol / MALClient

Not so small client app for Myanimelist.net - Windows 10 UWP & Android
GNU General Public License v3.0
354 stars 32 forks source link

Is there a way to show voice actors of only a particular language? #221

Open DeeeFoo opened 6 years ago

DeeeFoo commented 6 years ago

I'm not sure if this is a bug or if it was designed this way intentionally, but just thought I'd mention it anyway.

Whenever I go to the "Characters" tab on the Android app to view the characters' voice actors, it will show a mixture of Japanese and English voice actors. For example, one character will have their English voice actor listed, while another will have their Japanese voice actor listed. This only happens to shows that have been dubbed in both languages, obviously.

Is there way for it to show just the voice actors of a particular language? i.e. Show only the Japanese voices, or show only the English voices, etc. I'm on version 1.4.6.0 of the android app.

Here's a screenshot that illustrates what I mean: screenshot_2018-08-01-15-20-10

Drutol commented 6 years ago

Hello,

the data is grabbed as is from the website and since I assumed one VA per character it takes the first one listed on the webpage image

Do you think taking always Japanese (if present) one would be better? I don't really plan on changing the UI here unfortunately.

DeeeFoo commented 6 years ago

Hi,

Thanks for replying.

Ahh I see, so it's because the MAL website lists them that way (which is still odd, but whatever).

Yes, I do think that for most general use cases, it would be better to display only the Japanese voice actors, since all anime will have a Japanese voice cast at the very least (with exceptions). Would this be possible?

Best regards

Drutol commented 6 years ago

Definitely possible and quite easy to do you in fact.

DeeeFoo commented 6 years ago

Awesome. Thanks!

DeeeFoo commented 6 years ago

Hello,

Any updates on this? The app is still experiencing this same thing.

Drutol commented 6 years ago

I think I rage-quited while parsing this HTML a while ago.

DeeeFoo commented 6 years ago

Oh okay I see. That's fine, it was only a minor issue anyway, I can totally live with it.

Great job on the app though, it's very handy.

Drutol commented 6 years ago

I'll give it a shot one day. I'm now fixing more important things that appeared while I was abroad on holidays ^^