Drutol / MALClient

Not so small client app for Myanimelist.net - Windows 10 UWP & Android
GNU General Public License v3.0
354 stars 32 forks source link

[Long list] Bugs / Small suggestions #42

Closed Kimod closed 8 years ago

Kimod commented 8 years ago

First of all, I really love your app, like, really ^^ So after using it for a while I noticed a few things that bothered me, so I figured I would write them here, so they could get solved.

Bugs

Mobile only bugs

Suggestions

I hope that at least some of those bug fixes / suggestions will get implemented, so I could enjoy your app even more ^^ and also I hope, that some of those pictures helped to describe, what I meant

Drutol commented 8 years ago

Wow, good job listing those! Some of these are just api limitations, there is no specific data on certain page etc... It's hard to get the data :) I'll elaborate a bit more when I get to my computer. Thanks a lot!

Drutol commented 8 years ago

Bugs have been fixed, I'll look at suggestions tomorrow :)

I'll try to upload today new preview builds with these changes.

Kimod commented 8 years ago

Here is the bug in settings regarding drop down lists more explained, I hope you will understand now, because I don't know, how to make it clearer... http://puu.sh/q8jH1.png
Thank you for your fast responce and resolving that many bugs. shame that APIs are sometimes messy :(

Drutol commented 8 years ago

Ooh I get it now... It's stock behavior of combo box control and I didn't find any options to customize it. Changing it may prove more problematic than its worth ^^

Kimod commented 8 years ago

When I right click/long hold on Image in Article in "Articles", I would like an option to save it :question: How would you like to save it?

Well, on deskop, you can already save the image of the anime cover art, it opens save dialog and you can save it, so on deskop you can open save dialog and save it where you want it On mobile, you can't even save the anime cover art, so that's something, you forgot to add? Because for example in readit, when you click on "Save image as", then it opens file manager in the app. Also in readit, there is an option to "Save image" which saves the image to special folder in Images folder, so this is what i meant. Also for gifs, in readit, there is an option to "save gif as video", but I don't know why it does it this way, isn't .gif good enough?

Drutol commented 8 years ago

Hmm, it may be impossible. When rendering html (article in this case) special control is used which behaves like web browser and I have very limited options of its customisation (I even cannot change the look of scrollbar). You cannot save images in readdit when actual website is loaded unless it detects that link leads to single image and renders it in different way.

I could create list of all images in an article and allow to download them but I feel like there are more urging matters :)

Kimod commented 8 years ago

Big mobile bug

Bugs

Suggestions

So the next two will probably take you a long time, so you can put them on-hold, just the idea that you will consider and maybe add them in the future will make me happy. (Currently I'm really glad you inplemented characters in show details ^^)

So I still use the website for two things that your app can't do, so if you would implement those two things, you would make me really happy, but you would probably have to pull some things from html

Drutol commented 8 years ago

Is this big mobile bug still a thing? I believe I addressed it in last update... + it works on my machine ;d

I'm taking break from forums btw :D

Kimod commented 8 years ago

That mobile bug is still present on my device, according to my research, it has to do with scaling of the display, it will load on 150%, so it works on that scaling, but when I have the display in 200% scailing, it won't work...

Drutol commented 8 years ago

了解

Drutol commented 8 years ago

I was planning to send you new build today but I'm too tired to package everything now... Expect them tommorow :)

Drutol commented 8 years ago

Okay, now I'm going to look into history

Drutol commented 8 years ago

In the meantime...

Here are promised builds with stuff fixed as indicated in your last list :)

x64: https://1drv.ms/u/s!Am1xQK-HVf_IkdJe2T917pFMChEhnQ

ARM: https://1drv.ms/u/s!Am1xQK-HVf_IkdJf3uMnxmR-5yTxBg

Kimod commented 8 years ago

Daily dose of new bugs ^^

"Big mobile bug"

Bugs

Drutol commented 8 years ago

About history... what do you think about this organisation? Each section (today, last week etc.) will have grouped anime/manga and in these groups all relevant updates will be displayed.

(Just displayed raw processed data) image

Kimod commented 8 years ago

If you saw the comment before editing, sorry I was blind, nevermind... :D Looks pretty solid ^^

Maybe a little question, when the whole week isn't finished, the days in that week will show up below each other on the left? Won't that make that column too long? Or you will make "This week" and show them similarly like "Last week"?

Drutol commented 8 years ago

Let me do the layout and I'll post ss once I'm done :)

Drutol commented 8 years ago

Something like this? There will be some empty space and I don't really know what to do about it :(

image

image

Kimod commented 8 years ago

Looks good, really good ^^ any word on viewing somebody else's History? Also on the website you can delete each entry. Could you implement something like that?

And the scollbar isn't at the edge in the first pic :D

Drutol commented 8 years ago

Okay, this the build with fixes from your last list + history + profile comments.

I don't know how bugged this is but you seem to have natural talent for finding bugs/issues. And I've little time to check this now thoroughly. I want to upload this version feature wise to the store tommorow ^^

x64 https://1drv.ms/u/s!Am1xQK-HVf_IkdMGLdSF12rZOZAODw

Drutol commented 8 years ago

Uhuh I see crashes ;d

Kimod commented 8 years ago

Oh I will post this commend now when you are here and maybe edit it later if I find something :)

Love the history though, better than I imagined ^^

If you have time for a few issues that I recently discovered

It is harder and harder to fing bugs/issues :D

Drutol commented 8 years ago

How many times did this app crash on most recent build?

Kimod commented 8 years ago

Only sometimes when I opened History, elsewhere it didn't crash at all, well I have one bug regarding empty list and clicking on Select one at random, but I believe that it was there before

Drutol commented 8 years ago

So it didn't crash ... image ... 29 times?

Kimod commented 8 years ago

Well, it is possible... :D I tried to find reliable way to make it crash, but didn't find any

Drutol commented 8 years ago

Okay, I was hoping that crash analytics on windows store were more accurate xd

Drutol commented 8 years ago

I'll upload next build in a few minutes and I'm off to preparing mobile views.

Drutol commented 8 years ago

Okay, play with this and I'm going to start working on mobile...

x64 4.4.11.0 https://1drv.ms/u/s!Am1xQK-HVf_IkdZiIIjbT12-cSQ3gw

Kimod commented 8 years ago

ok, it doesn't crash now, which is always good, right?

Drutol commented 8 years ago

First mobile build with new stuff: (I'd like to treat these like RC's without changelog but we all know how this will turn out...)

ARM v4.4.14.0 https://1drv.ms/u/s!Am1xQK-HVf_IkdZjnvZfo5-3ZfuZ2w

x64 v4.4.13.0 https://1drv.ms/u/s!Am1xQK-HVf_IkdZkScENmvUmNZHslQ

Kimod commented 8 years ago

First I tested mobile

But anything besides that mobile bug regarding history on small scaling are pointless things so you shouldn't worry about making this version public (at least for desktop, if you want to fix that mobile history bug is up to you... ^^)

Drutol commented 8 years ago

Fixed this mobile history:

03.08.2016 -  v4.4.16.0 & v4.4.15.0

Added profile comments.
Added profile history.
Improved organisation of profile page.
Gave some love to light theme.
Search will be now more accurate and there will be delay after typing in query.
Resolved issues with being unable to load more items on mobile.
Selecting at random will be now smarter.
Fixed visual bug with start/end dates.
Fixed bug where refresh button could create duplicates.
Status bar will now correctly show show titles and other headers.
You can now select and copy text from header in anime details.
Navigation mechanisms have been rewritten.
Profile page will no longer show empty favourites.
Resolved with adaptation issues in recommendations page.
Kimod commented 8 years ago

Found some bugs and also bugs from earlier lists (I did this because I wanted them to be in one place ^^)

Some mobile only bugs

Love the flowers, because thanks to them is my list fabulous ^^

Drutol commented 8 years ago

I'll resolve these over the weekend as I'm working on demo version of my internship app right now. Additionally I'm planning to either add character details or forums in "beta" version. And those dreaded ads will appear next week...

Drutol commented 8 years ago

Once more... screw ads.

Fixed some things, some of them I don't even want to touch and some are left for tommorow :) Because of new AU emojis we are switching white empty checkmark to :white_flower: because why not :D

Kimod commented 8 years ago

It's that time again! More bugs, Yeeey ^^

Crashes

Not really bugs

Mobile only

As always, if you didn't get something what I tried to explain here in my poor english, feel free to ask ^^ (that's why I have gif/image for almost everything, you don't have to view them all, they are there to better explain the issue) Also if you were wondering, that thing with different heights on favorite anime and characters in profile when I was switching monitors wasn't fixed, you can skip this, just letting you know ^^

Drutol commented 8 years ago

How is/was railgun/index?

Kimod commented 8 years ago

Ohh, I really enjoyed Index and I think that I'm enjoying Railgun even more, so many best grillz :3 I really like how it's lighthearted and the comedy was done just right 👌👌

Drutol commented 8 years ago

Yup, many best girls ^^. I deem first railgun the weakest of four but still very good nontheless. I'm even going through light novels now and next contestant is making her appearance. Let's hope for index3 :D

Drutol commented 8 years ago

I also feel like this list is becoming too long, how about creating new issue next time?

Kimod commented 8 years ago

You are probably right, I didn't want to spam your issues with my lists ^^ So next time, instead of commenting with the list, I will create new issue.. And a little question: Should I copy previous bugs to new issue, if you didn't fix them and didn't even coment on them. for example that issue with scrollbar not being on the edge?

Drutol commented 8 years ago

Yeah, copy them just in case...

image

This update will take a while because of the amount of various stuff I'm changing :)

Drutol commented 8 years ago

New build available in #29. Open new issue if you happen to find something (what am I even talking about ^^ )