Drutol / MALClient

Not so small client app for Myanimelist.net - Windows 10 UWP & Android
GNU General Public License v3.0
354 stars 32 forks source link

Native forums! Aftermatch! #96

Closed Drutol closed 7 years ago

Drutol commented 7 years ago

They are almost done and quite usable in my opinion :D I'd like to release them next week and I'd like to test them before it'll crash world-wide.

What new?

What's missing?

Download

This build is built in debug configuration which means it'll work slower but I'll get very detailed crash reports. See #73

rahulrameshnair commented 7 years ago

@Drutol The DPI is 166. Why does that matter?

I was recently watching Re:Zero anime, then dropped it. Then started watching Drifters.

rahulrameshnair commented 7 years ago

Also, if the forum errors are rectified, please upload the new package to the store :)

Drutol commented 7 years ago

Uploading new store package isn't something I can do instantly (you cannot certify during weekends anyway), I'll upload test packages today/tomorrow.

166!? Wow... That's the reason why it's broken, I don't know how to calculate it to "magical Microsoft units", can you get a normal monitor like everybody else? /s

rahulrameshnair commented 7 years ago

😞 its my laptop. I cant tear off the screen, u dummy.

Well, i will wait for the bug fixed build. Will rely on website till then.

Sent from my iPad

On Feb 4, 2017, at 11:56 AM, Piotr Szymczak notifications@github.com<mailto:notifications@github.com> wrote:

Uploading new store package isn't something I can do instantly (you cannot certify during weekends anyway), I'll upload test packages today/tomorrow.

166!? Wow... That's the reason why it's broken, I don't know how to calculate it to "magical Microsoft units", can you get a normal monitor like everybody else? /s

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Drutol/MALClient/issues/96#issuecomment-277422929, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJCZTtUZy2eiY-nVEMGnakRx1WyRewm-ks5rZBoRgaJpZM4LwioZ.

Drutol commented 7 years ago

This is my laptop... you can certainly do it :D

wp_20170204_08_28_09_pro

rahulrameshnair commented 7 years ago

So, which laptop are u using now? Or your system config?

Drutol commented 7 years ago

I don't use laptop ^^ My monitors have standard 96dpi, and making sure that it both works for me and you is going to be problematic... maybe simple ratio will help if it works on 96 ;d

Drutol commented 7 years ago

Found a bug which could result in missing replies.

rahulrameshnair commented 7 years ago

Ohh, ok ok. Well I don't use much UWP apps, so I am not sure how scaling works in them. What about you? Other than Readit and MALclient, you use anyother app from the UWP store?

Ohh, :) that is nice, hopefully it gets resolved soon.

Drutol commented 7 years ago

MyTube is also great, and Groove of course!

The thing with scaling is that the height come in pixels from javascript and I have to manually convert them to uwp units which isn't something you do really often.

Drutol commented 7 years ago

Primitive bbcode "editor" image

rahulrameshnair commented 7 years ago

Nice, if everything is done, pack it into a build and upload to UWP store ^_^

Drutol commented 7 years ago

And I'll say for n-th time... uploading things to the store isn't a trivial thing so I can't just throw new builds every second + certification during weekends is almost impossible.

My lumia has 144 dpi and everthing scales correctly... are you sure that every post had scroll enabled?

rahulrameshnair commented 7 years ago

Yup. I usually post in the recommendations section. In it all posts and replies had this scroll enabled. Let me ask, even though it is a native forum, you are scrapping the threads from the MAL forums, right? So why is it not possible to just show the posts like it was done before? I know the answer is not gonna be simple, but if possible explain; I can learn something.

Drutol commented 7 years ago

By native forum I call one that's not one big web view with whole page restyled by JavaScript. Each post now has little WebView which needs to be manually resized to avoid scroll and I don't know why it doesn't work for you as dpi is not the case here. Each web view is fed with extracted html from page + with cutom css + javascript that handles extracting actual size.

Rendering this in xaml would probably take 5 years and a research team... + this works pretty damn good except for you ;d

Are these containers of different sizes at least? ss/gif appreciated

rahulrameshnair commented 7 years ago

image

This is what I mean, when these containers become scrollable, the page does not scroll well unless from outside these message containers.

Drutol commented 7 years ago

You are not using touch input right?

Drutol commented 7 years ago

Make SS of first post of my thread on forums

rahulrameshnair commented 7 years ago

Yes it is a touch enabled screen. -_- But am using my touchpad. I just tried scrolling with finger (touch), that works flawlessly. These containers become active only when using touchpad.

Drutol commented 7 years ago

It shouldn't work with touch... on phone version I hat to put transparent panels that captured all inputs before WebView which would disappear after tap enabling interaction with WebView. (WebView scrolls always with touch regardless of what I try). I don't have any touchpads around to test it.

Using mouse scroll wheel should work for you then?

rahulrameshnair commented 7 years ago

Well, I am not sure why, as touch input, there is no scrolling of container. Is not that a good thing?

The only issue is with touchpad. but its fine, i can scroll from the left hand side (outside the container area). So you focus on remaining troubleshooting, leave this container issue for the time being.

Drutol commented 7 years ago

It's not a good thing because it works differently on phone and screens with touch. Touchpad should behave as scroll wheel and it's not.

I'm at loss now... I'm implementing the same strategy as on phone right now i.e. if touch is present hide WebView behind another element.

rahulrameshnair commented 7 years ago

:P Something just occurred to me. I was thinking, how awesome it could be to say "Hey Cortana: Check for new anime episodes today" and lock-screen notifications from the app "New episode of Drifters airs today at 10:00pm EST"

I know you don't like Cortana, but just placing all the potatoes on the table ^_^

Drutol commented 7 years ago

You know what? Take an example from @Kimod and make big issue with all your requests on the

My motivation increases when I see ordered lists xd Test version should be available in a few hours.

rahulrameshnair commented 7 years ago

@Drutol Ya I understand what you mean by "it's not supposed to do that". I think I told you I wrote a webscrapper in python to scrap images from a webpage and all the concurrent pages linking from the webpage and store it into my desktop. But for some reason the program terminates after scrapping 3-5 pages. Still have no idea why it does that. -sighhhh-

Drutol commented 7 years ago

Well, I'm not sure how can I help you with this much info xd

Drutol commented 7 years ago

Click through this one :)

https://github.com/Drutol/MALClient/issues/73

Drutol commented 7 years ago

@sinofanger Call to arms :) I want to send this for certification in a few hours ^^

rahulrameshnair commented 7 years ago

😨 I am actually outside right now, just roaming inside a Playstation store.

I think this build will not be having any issue with forum. Just a feeling.

Drutol commented 7 years ago

I think this build will not be having any issue with forum. Just a feeling.

Wishful thinking

Sure, take your time. I'd just like somebody to click through it from active forum user perspective ^^

rahulrameshnair commented 7 years ago

Lol, I am make up questions in forum just for checking out the app. I simply ask random questions like “which anime should I watch after Drifters?” etc. I am the least MAL forum user.

But yeah, I also think it will have least issues. I just saw the latest Macbook Pro lineup. The Mac OS is really top notch when it comes to design and a feeling of wholeness. I mean Windows 10 still looks like part Windows 7 with two Settings center (settings and control panel). sighhh

Drutol commented 7 years ago

Yeah you are missing on usb connectors and they are awfully expensive for what they offer hardware-wise. These things should die already. /rant

Just get hackintosh if you like macos... and yes I did happen to see the OS itself.

apple hater - 2017

rahulrameshnair commented 7 years ago

Lol, Its not like I plan on switching to Apple (unless they make a Mac which is detachable, touch-enabled or 2-in-1, which will never happen, I guess). What I am pointing out is the way in which apple design their software, their mail app, Mac OS; just their software. Like when we compare Apple music with Groove Music; that is what they are implying.

Drutol commented 7 years ago

I won't argue here as I've little experience with the apps there. I did have an iPhone a few years ago (3GS) and in my opinion it was unusable without jailbreaking, this was the best feature of that phone ^^.

rahulrameshnair commented 7 years ago

Ya, anyway, I seriously hope Windows 10 becomes more "full" when creators update releases this March.

Drutol commented 7 years ago

So what's missing?

rahulrameshnair commented 7 years ago

proper contextual menus, depreciating control panel. proper icon sets, making Edge more stable, MAPI for mail.. etc etc...

rahulrameshnair commented 7 years ago

SUGGESTION:

You said you cannot do anything about the notifications, right? Why not provide an option to select "Mark all as read" or "Mark as read" for individual notification, instead of "open topic"?

That way people can easily close notifications, so that they never come back again. The app shows me at least 20 old read notifications from the past every single day.

Drutol commented 7 years ago

So why won't you mark them as read?

rahulrameshnair commented 7 years ago

Because there is no "mark as read" option. The only option is "open topic" and "dismiss". Dismiss does not work, I am not going to open topic of all the 20+ old notifications.

Drutol commented 7 years ago

You have button "Mark as read" in notifdixation hub

rahulrameshnair commented 7 years ago

Nope. I can only see two buttons for MAL notifications: "Open Topic", "Dismiss". For apps like mail I can see the option "Mark as Read".

Drutol commented 7 years ago

You have button "Mark as read" in notifdixation hub

Drutol commented 7 years ago

I'll add these today though

Drutol commented 7 years ago

@sinofanger Time's up. I'm uploading packages to the store.

rahulrameshnair commented 7 years ago

Sorry about not being able to test it. Was and is stuck with some assignments. I could see that it reached the store. That was pretty fast. I will update it and let you know how it is... :) @drutol

rahulrameshnair commented 7 years ago

@Drutol By the way, I wanted to ask you, after Android version of the app is released, what is your plan? I asked because by the time android app also becomes popular, we will have a huge fan base...

Drutol commented 7 years ago

By the time Android app is finished whole world will be conquered by Windows 10 Mobile :D /s

I've no clue to be honest, I cannot foresee so far in the future ^^

rahulrameshnair commented 7 years ago

Lol, by that time I just wish Windows 10 mobile does not become an exhibit at the museum of natural history. I think, android app will become a lot more popular. How many installs of the Windows 10 app have taken place so far? You will be having some sort of analytics in the windows store, right?

Drutol commented 7 years ago

4k downloads after 10 months + 1,2k monthly users as of know