Drutol / RaidOps

EPGP , Bidding and Loot Distribution addons for WildStar.
GNU General Public License v2.0
1 stars 1 forks source link

Acterra Drop #466

Open Larnen opened 8 years ago

Larnen commented 8 years ago

Hiya, Can you confirm if you're still doing fixes to RaidOps? The last patch seems to have broken RaidOps totally when you try and assign loot (master looter issue) which then disables the whole thing. Net effect nothing is working.

Can grab some error codes if you're still maintaining it, but haven't seen any updates for a while, so not sure!

Thanks :) Larn

Drutol commented 8 years ago

Yeah , I don't mind pushing out a few fixes :) There was nothing in API changelog as far as ML is concerned so I assumed that everything works... Send me those codes and I'll look into it.

Larnen commented 8 years ago

Will do, we're raiding tonight so will get them then. Last 2 weeks its been a bug when you actually assign the loot. Glad to hear you're still around! Looks like 90% of addons don't have any bug fixes any more!

Larnen commented 8 years ago

Error was (hand copied from screenshot):

Addons\RaidOps\BID.lua:2469:attempt to call method 'GetName' (a nil value)

stack trace:

Addons\RaidOps\BID.lua:2469: in function Addons\RaidOps\BID.lua:2466>(tail call): ?

Drutol commented 8 years ago

I'm pretty busy... so I cannot test it myself right now.

function DKP:OnLootAssigned(luaCaller,nLootId,objItem, strLooter)
    local DKPInstance = Apollo.GetAddon("RaidOps")
    if DKPInstance.bIsSelectedGuildBank and string.lower(strLooter) == string.lower(DKPInstance.tItems["settings"]["ML"].strGBManager) and Hook.bSelectedGuildBank then strLooter = "Guild Bank" end
    Event_FireGenericEvent("GenericEvent_LootChannelMessage", String_GetWeaselString(Apollo.GetString("CRB_MasterLoot_AssignMsg"), objItem:GetName(), strLooter))
end

Try to swap this code with function beginning with line 2466 of BID.lua

It's my fault I have overlooked this update ;d

Larnen commented 8 years ago

Updated, may get a chance to test tonight. Thanks :)

Drutol commented 8 years ago

You can just go kill some low level mobs while in party with ML on on and it'll simulate raid just fine.

Larnen commented 8 years ago

...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2469: attempt to index local 'objItem' (a nil value) stack trace: ...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2469: in function <...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2466> (tail call): ?

Larnen commented 8 years ago

And just to confirm that error was after making the code change suggested above

Drutol commented 8 years ago

2nd guess...

function MasterLoot:OnLootAssigned(nLootId, objItem, strLooter)
    Event_FireGenericEvent("GenericEvent_LootChannelMessage", String_GetWeaselString(Apollo.GetString("CRB_MasterLoot_AssignMsg"), objItem:GetName(), strLooter))
end

replace function in master loot dependency addon at line 474 (there's one .lua file)

I don't even have wildstar downloaded so I'm sorry for not being able to test it by myself. :(

Larnen commented 8 years ago

Doesn't seem to do anything at all now - loot that is above the loot threshold for master looter seems to just get round robbined.

Drutol commented 8 years ago

Did the addon load properly? (dependency) I'll try to download W* over the weekend.

Larnen commented 8 years ago

Ok working again with the same error:

...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2469: attempt to index local 'objItem' (a nil value) stack trace: ...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2469: in function <...pData\Roaming\NCSOFT\WildStar\Addons\RaidOps\BID.lua:2466> (tail call): ?

Can confirm update above was made to MasterLooterDependency.

NO idea why nothing has working previously - WS being buggy in some odd way I guess

Drutol commented 8 years ago

Ehh , I'll check ehis tommorow. Let me know when you are going to be online.

Larnen commented 8 years ago

Tomorrow i can be online any time before 4pm uk time as long as ive a bit of notice

Drutol commented 8 years ago

I'm coming home around this hour so be prepared ^^

Drutol commented 8 years ago

I'm online now ;d

Writ here if you happen to be online

Larnen commented 8 years ago

Hi. Sorry missed your message on here! Let me know when you're free next and I'll be on W*

Drutol commented 8 years ago

I'm online now

Edit. And I'm gone xd

I should be available tommorow after 13:00 (uk time)

Drutol commented 8 years ago

okay , I'm up ^^

Larnen commented 8 years ago

NCSoft Login Service timeout atm. Will be on as soon as that clears.

They're saying it'll be up at 3pm UK time. But will try from 2 as I'll be busy between 3 and 4:30

Drutol commented 8 years ago

Downloading update

Still down

Larnen commented 8 years ago

Its up. Am on now for about another 40m, then will be offline for about 45m and then online the rest of the evening (but raiding from 7;30)

Drutol commented 8 years ago

I'm online

Drutol commented 8 years ago

Stuff works once again