Closed Drvi closed 2 years ago
Merging #9 (4b2f7fe) into master (d464ab7) will decrease coverage by
3.14%
. The diff coverage is87.86%
.:exclamation: Current head 4b2f7fe differs from pull request most recent head 7721d7d. Consider uploading reports for the commit 7721d7d to get more accurate results
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 89.52% 86.38% -3.15%
==========================================
Files 22 23 +1
Lines 2502 2629 +127
==========================================
+ Hits 2240 2271 +31
- Misses 262 358 +96
Impacted Files | Coverage Δ | |
---|---|---|
src/ProtocolBuffers.jl | 85.71% <ø> (ø) |
|
src/codegen/modules.jl | 79.74% <ø> (-3.59%) |
:arrow_down: |
src/precompile.jl | 0.00% <0.00%> (ø) |
|
src/codegen/encode_methods.jl | 68.59% <73.46%> (-22.62%) |
:arrow_down: |
src/lexing/Lexers.jl | 87.27% <77.77%> (-3.02%) |
:arrow_down: |
src/codegen/CodeGenerators.jl | 84.84% <83.87%> (-15.16%) |
:arrow_down: |
src/parsing/utils.jl | 73.40% <97.14%> (+0.16%) |
:arrow_up: |
src/codegen/types.jl | 94.05% <97.43%> (-0.84%) |
:arrow_down: |
src/codegen/decode_methods.jl | 98.88% <100.00%> (+0.05%) |
:arrow_up: |
src/codegen/defaults.jl | 96.38% <100.00%> (ø) |
|
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d464ab7...7721d7d. Read the comment docs.
precompile.jl
filedefinitions
used be type-annotated forAbstractProtoType
, now it has much more preciseUnion{MessageType, EnumType, ServiceType}
type annotation.NamedTuple
-- this meant creating a new type for each parsed enum. Now we store the enumerated names and integer values in plain arrays.Generators
andIterators.{map,flatten}
that were used in type-unstable context were replaced with custom iteration/traversal functions. The type unstable context was usually iterating/traversing fields with unpredictable types.@nospecialized
were sprinkled around (mostly avoiding specialization of parametrized field types which didn't really do anything type-specific)print
calls with multiple input arguments were simplified to only be given string inputsmaster
:PR
: