search

DrylandEcology / STEPWAT2

folder
4 stars 5 forks source link

Make bvt rgroup-specific #347

Closed kpalmqui closed 4 years ago

kpalmqui commented 5 years ago

Currently, bvt, defined in sxw_bvt.in, is multiplied by _resource_cur for each STEPPE functional group in the final step of determining normal resource availability for the current year. This variable has a very large impact on reource availability, growth, and mortality, but unfortunately is poorly documented.

We believe that is essentially translates resource availability in cm to resource availability in terms of grams of biomass that can be supported off those resources. Perhaps in a sense representing how efficient functional groups are at responding to available resources through biomass increment. However, we provide only one input value that is utilized for all functional groups (900 g biomass / 23 cm transp). This issue will add bvt values for each functional group as we expect functional groups to vary significantly in their growth response to resource availability. This issue will require thorough testing of the impact of functional group specific bvt values.

It is unclear where the default values of 900 g biomass / 23 cm of transpiration came from and this should be carefully re-evaluated.

kpalmqui commented 5 years ago

@fdpierson for now, specify 900 g biomass/ 23 cm for each functional group. I will then update and test them accoridngly.

I also suggest we move this parameter into rgroup.in. It is currently held in sxwbvt.in

kpalmqui commented 4 years ago

@fdpierson reassigning to @chaukap

chaukap commented 4 years ago

@kpalmqui BVT is also RGroup-specific and ready to test.

kpalmqui commented 4 years ago

@chaukap this is great and working as expected. It may take a bit of time and thought to adjust the BVT values for each rgroup. As such, I would like to move forward with the current values we have and get this folded into master.

However, before we do so, we need to update the Input_Rgroup.csv file within rSFSTEP2 to now include BVT. I will open a new issue for that.

kpalmqui commented 4 years ago

@chaukap should we close this issue and the other issues in this milestone and open a pull request for this branch, so it can be folded in ASAP after the phenology branch of rSFSTEP2 is folded in?

chaukap commented 4 years ago

@kpalmqui That sounds good I'll get on it!