search

DrylandEcology / STEPWAT2

folder
4 stars 5 forks source link

Remove old code / unnecessary features of wildfire-cheatgrass implementation #524

Closed kpalmqui closed 1 year ago

kpalmqui commented 2 years ago

Remove outdated code associated with the old wildfire-cheatgrass implementation. This includes code that calculates cheatgrass percent cover (_getCheatgrassCover), as it is no longer needed in the new implementation, which is based on biomass.

mnovo323 commented 2 years ago

I left _getCheatgrassBiomass in the code, but it could also be removed because it is no longer needed to calculate cheatgrass cover. The only place the function is called now is in Mort_EndOfYear to find if cheatgrass is present. Because that is the only place it is used, we could just move the function body directly there, but that could make that section of code "messier".

kpalmqui commented 2 years ago

@mnovo323 yes, let's remove _getCheatgrassBiomass and the check to cheatgrassBiomass in Mort_EndOfYear as it is no longer needed.

kpalmqui commented 1 year ago

Resolved by https://github.com/DrylandEcology/STEPWAT2/commit/c5f21aa26577b9aa237244d29c682c91f7641cd7 and https://github.com/DrylandEcology/STEPWAT2/commit/100f5ca8f008bc1751663d408116a2ee6e970f6b