search

DrylandEcology / rSFSTEP2

R program that interfaces with the STEPWAT2 C code and runs in parallel for multiple sites, climate scenarios, disturbance regimes, and time periods
0 stars 1 forks source link

Derived litter fractions and biomass fractions exceed 1.0 #194

Closed kpalmqui closed 4 years ago

kpalmqui commented 4 years ago

We are now derving all input values within sxwprod_v2.in dynamically based on the monthly temperature values for a given site-scenario. The parameters in sxwprod_v2.in convert annual STEPPE funcitonal type biomass to monthly SOILWAT functional type biomass, % live, and litter for each year's SOILWAT2 run.

When looking carefully at the Figures generated for biomass, % live and litter, I noticed that biomass fraction values and litter fraction values are exceeding 1 for some scenarios. This should not happen. While the monthly values do not need to sum to 1.0, any given monthly value cannot exceed 1.0, as these represent percentages. See the description in sxwprod_v2.in and demonstration of the problem here:

a cool grass_46-52_biomass_graph

LITTER_46-53_graph

@chaukap can you help to resolve this issue by capping all derived values at 1.0? While I did not notice this problem yet for % live, that needs to be capped at 1.0 as well.

chaukap commented 4 years ago

@kpalmqui This issue should be resolved.

kpalmqui commented 4 years ago

This issue has been resolved by the above two commits.