DrylandEcology / rSFSTEP2

R program that interfaces with the STEPWAT2 C code and runs in parallel for multiple sites, climate scenarios, disturbance regimes, and time periods
0 stars 1 forks source link

Constrain litter, %live, and biomass fractions by the sum of the default fractions #197

Closed kpalmqui closed 4 years ago

kpalmqui commented 4 years ago

@dschlaep and I noticed that litter, %live, and biomass fractions that are derived on the fly based on future monthly temperatures are often quite larger for most months relative to current and default (input) conditions. Biologically, this does not make sense.

Because the future is warmer, values are increasing in almost every month with few constraints. We believe a logical and realistic initial solution to this problem is to constrain all derived values for each functional type such that their sum across all months is equivalent to the summed monthly default values for that functional type.

@chaukap let me know if you have any questions.

chaukap commented 4 years ago

@kpalmqui Check out the solution I just pushed. I realized that the easiest way to do this was to first normalize the values to sum to 1, like phenology, then multiply each value by the sum of the fractions read in from inputs.

kpalmqui commented 4 years ago

@chaukap this looks great! I will test this over the weekend and report back.

kpalmqui commented 4 years ago

@chaukap @dschlaep The above commit has resolved this issue. The percent live, biomass, and litter fraction Figures look much more reasonable and are more in line with phenological activity now. The large increases from current to future conditions have disappeared. I am happy with these results and therefore I am closing this issue.

Old litter implementation: Site5_OLD_LITTER_46-53_graph

New litter implementation: Site5_NEW_LITTER_46-53_graph

Old biomass implementation: Site5_OLD_p cool grass_46-52_biomass_graph

New biomass implementation: Site5_NEW_p cool grass_46-52_biomass_graph

chaukap commented 4 years ago

@kpalmqui That's great to hear!