search

DrylandEcology / rSFSTEP2

R program that interfaces with the STEPWAT2 C code and runs in parallel for multiple sites, climate scenarios, disturbance regimes, and time periods
0 stars 1 forks source link

Remove scaling of phenological activity values to sum to 1.0 #202

Closed kpalmqui closed 4 years ago

kpalmqui commented 4 years ago

@dschlaep determined that phenological activity values do not need to sum to 1.0 for transpired water to be partitioned correctly. In fact, scaling them to 1.0 causes undesirable behavior. See https://github.com/DrylandEcology/STEPWAT2/issues/430 for more explanation.

This issue will remove lines 668-671 in Main.R that rescale the phenological activity values coming out of scale_phenology to 1.0.

chaukap commented 4 years ago

@kpalmqui Should I add a check to make sure that no single phenological value is greater than 1, just in case?

kpalmqui commented 4 years ago

@chaukap for the time being, we are going to use the unscaled values with no additional adjustments. So no - you don't need to add a check to ensure that individual phenological activity values =< 1.0.