DrylandEcology / rSFSTEP2

R program that interfaces with the STEPWAT2 C code and runs in parallel for multiple sites, climate scenarios, disturbance regimes, and time periods
0 stars 1 forks source link

Update phenological activity values in InputData_phenology.csv so they no longer need to sum to 1.0 #203

Closed kpalmqui closed 4 years ago

kpalmqui commented 4 years ago

Analagous to https://github.com/DrylandEcology/STEPWAT2/issues/431. I will update these in rSFSTEP2 once the issue in STEPWAT2 is resolved.

@chaukap FYI

kpalmqui commented 4 years ago

A bit more context for this issue:

SXWResources->_roots_active_rel[Iglp(g, l, p)] = SXWResources->_roots_max[Ilg(l, g)] SXWResources->_phen[Igp(g, p)] sizes[g] / sum_all_veg_types[Ilp(l, p)] requires that: _phen is comparable among groups (for each month) _roots_max is comparable among groups (for each soil layer)

And additionally that: _phen, and _roots are relative to each other in a manner that represents our expectations of their relative importance

The equation works on all groups together but for each month and each soil layer separately, i.e., values of fraction of roots and phenological activity of a given soil layer in a given month are treated independently of values in other soil layers and other months. The only comparison made is the one among groups (sum_all_veg_types is the sum across groups). So, in this equation the fraction of root represents for each soil layer separately the “competitive” ability of a functional group to extract water. Correspondingly, in this equation the phenological activity represents for each month separately the “competitive” ability of a functional group to extract water. As example, if a group has a value of 1 for fraction of root in layer 2 and another group has a value of 0.5 in that layer; then the equation considers that the first group is twice as able to extract water from that soil layer.

The spreadsheet below contains the original phenological activity values for each STEPPE functional group (sum to 1.0 across all months), along with the new proposed phenological activity values (do not sum to 1.0 across all months, indicate relative importance of activity for each functional group within a given month).

Here I chose to:

Set phenological activity >0 if %live was >0 Set phenological activity to 1.0 for at least once month for each functional group. Feedback requested from @dschlaep once you return from your trip. I will also seek feedback from John and Bill.

phenological.activity.xlsx

kpalmqui commented 4 years ago

Small updates to phenological activitiy as documented on issue #431 of STEPWAT2.

phenological.activity.xlsx

kpalmqui commented 4 years ago

Resolved by https://github.com/DrylandEcology/rSFSTEP2/commit/91891a8c19436608bbfd259bf8ae96f839a8641e and https://github.com/DrylandEcology/rSFSTEP2/commit/5a9816056e08d65aeaff3a7a0d0b43abc71765c7