search

DrylandEcology / rSFSTEP2

R program that interfaces with the STEPWAT2 C code and runs in parallel for multiple sites, climate scenarios, disturbance regimes, and time periods
0 stars 1 forks source link

Create shell scripts to call compareFiles.R on a computing cluster #218

Closed chaukap closed 4 years ago

chaukap commented 4 years ago

@kpalmqui I just tested this commit on Teton using some of the DIST directories you generated in your last rSFSTEP2 run. The tasks completed and the output was generated. There is one bug where the job.txt file will read "Site noid done!" which I will fix with my next commit.

kpalmqui commented 4 years ago

@chaukap thanks for the update! Which folder did you execute this in?

I ask becasue I ran the shell script last night for all 91 sites in the folder for my recent runs (rSFSTEP2.Feb2020) and it succesfully completed.

chaukap commented 4 years ago

@kpalmqui I copied R_programs 1 and 2 from your runs last night, deleted the output, then submitted the job. Did you use the compare_sbatch.sh script?

kpalmqui commented 4 years ago

@chaukap I used compare_sbatch.sh and sample. sh by embedding them in the relevant folders.

kpalmqui commented 4 years ago

@chaukap so no conflicts with our testing activities which is good! :)

chaukap commented 4 years ago

@kpalmqui Great! Just making sure that you didn't run into any problems.

kpalmqui commented 4 years ago

@chaukap no issues with executing the new shell script.

However, we failed to remember to update the yaxis limits for the phenological activity figures. All of the Figures I generated last night for phenological activity are mostly useless (see below). The rest of the Figures look good.

sagebrush_19-27_graph

chaukap commented 4 years ago

@kpalmqui sorry about that! I just bumped the y limit to 1.2 in commit b3c0cb1

kpalmqui commented 4 years ago

@chaukap I regenerated these Figures based on commit https://github.com/DrylandEcology/rSFSTEP2/commit/b3c0cb19a8b34921759999aae3de87b05c65b099 but there are still some issues with the Figures not being visible. Rather than fixing the ylim, can we derive it and set it on the fly using max(phenological activity)?

a cool grass_19-27_graph

chaukap commented 4 years ago

@kpalmqui I just pushed a commit to dynamically set ylim.

kpalmqui commented 4 years ago

@chaukap still some slight problems with the legend cutting off the Figures. Would it be possible to dump "sxwphen.hydrid-delta-3mod", which would shorter all the names substantially.

p cool grass_1-9_graph

chaukap commented 4 years ago

@kpalmqui My latest commit should finally resolve this issue. I shortened the legend values significantly and I switched the phenology legend to the upper right side.

kpalmqui commented 4 years ago

@chaukap It certaintly did - looks great. I did a set of test runs with 53 climate scenarios and none of the phenological activity Figures are cut off now. Here is an example:

a cool grass_46-53_graph

Therefore, I am going to close this issue. Thank you!