DrylandEcology / rSFSW2

rSFSW2: A R package to create soil water balance simulation experiment
GNU General Public License v3.0
8 stars 7 forks source link

Is there a way to disable the "make_dbOutput" function? #371

Open CaitlinA opened 5 years ago

CaitlinA commented 5 years ago

@dschlaep

I am interested in disabling the make_dbOutput function when sim_aggregate is FALSE

If I am understanding sim_aggregate correctly, then when sim_aggregate (as well as concat_dbOut) is set to FALSE in the SFSW2_project_code.R there is no reason to make an output DB. This could be a huge time saver.

What do you think?

dschlaep commented 5 years ago

I agree that this would be a good enhancement. However, the existing code was built around the assumption that dbOutput was always requested.

There are several crucial parts of the wrapper that rely on dbOutput. For instance,

As a work-around until someone implements this enhancement: use quickprepare_dbOutput_dbWork to locally create dbOutput once, and then copy it in the correct/expected places so that each call to the wrapper (e.g., on an expensive machine) does not need to create it's own copy.

CaitlinA commented 5 years ago

I think that is a good solution for now. Thanks.

On Tue, Nov 5, 2019 at 2:40 PM Daniel R Schlaepfer notifications@github.com wrote:

I agree that this would be a good enhancement. However, the existing code was built around the assumption that dbOutput was always requested.

There are several crucial parts of the wrapper that rely on dbOutput. For instance,

  • making sure that dbWork is up-to-date calls recreate_dbWork which uses dbOutput
  • the main simulation function do_OneSite uses information from dbOutput in several cases, e.g., to locate weather data

As a work-around until someone implements this enhancement: use quickprepare_dbOutput_dbWork to locally create dbOutput once, and then copy it in the correct/expected places so that each call to the wrapper (e.g., on an expensive machine) does not need to create it's own copy.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/DrylandEcology/rSFSW2/issues/371?email_source=notifications&email_token=ADGR572BN77UW6TG5VCZXLTQSHR2NA5CNFSM4JJJTYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDENPFY#issuecomment-550033303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGR57YONNOIU4KCJCGMGN3QSHR2NANCNFSM4JJJTYMQ .

-- Caitlin Andrews Ecologist Southwest Biological Science Center U.S. Geological Survey Mobile: 802-922-3494 Office: 928-556-7036