Open CaitlinA opened 5 years ago
I agree that this would be a good enhancement. However, the existing code was built around the assumption that dbOutput
was always requested.
There are several crucial parts of the wrapper that rely on dbOutput
. For instance,
dbWork
is up-to-date calls recreate_dbWork
which uses dbOutput
do_OneSite
uses information from dbOutput
in several cases, e.g., to locate weather dataAs a work-around until someone implements this enhancement: use quickprepare_dbOutput_dbWork
to locally create dbOutput
once, and then copy it in the correct/expected places so that each call to the wrapper (e.g., on an expensive machine) does not need to create it's own copy.
I think that is a good solution for now. Thanks.
On Tue, Nov 5, 2019 at 2:40 PM Daniel R Schlaepfer notifications@github.com wrote:
I agree that this would be a good enhancement. However, the existing code was built around the assumption that dbOutput was always requested.
There are several crucial parts of the wrapper that rely on dbOutput. For instance,
- making sure that dbWork is up-to-date calls recreate_dbWork which uses dbOutput
- the main simulation function do_OneSite uses information from dbOutput in several cases, e.g., to locate weather data
As a work-around until someone implements this enhancement: use quickprepare_dbOutput_dbWork to locally create dbOutput once, and then copy it in the correct/expected places so that each call to the wrapper (e.g., on an expensive machine) does not need to create it's own copy.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/DrylandEcology/rSFSW2/issues/371?email_source=notifications&email_token=ADGR572BN77UW6TG5VCZXLTQSHR2NA5CNFSM4JJJTYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDENPFY#issuecomment-550033303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGR57YONNOIU4KCJCGMGN3QSHR2NANCNFSM4JJJTYMQ .
-- Caitlin Andrews Ecologist Southwest Biological Science Center U.S. Geological Survey Mobile: 802-922-3494 Office: 928-556-7036
@dschlaep
I am interested in disabling the
make_dbOutput
function whensim_aggregate
isFALSE
If I am understanding
sim_aggregate
correctly, then whensim_aggregate
(as well asconcat_dbOut
) is set toFALSE
in the SFSW2_project_code.R there is no reason to make an output DB. This could be a huge time saver.What do you think?