DrylandEcology / rSOILWAT2

A R package for SOILWAT2
GNU General Public License v3.0
10 stars 4 forks source link

SOILWAT2 Threadsafety and Reentrancy #234

Closed N1ckP3rsl3y closed 1 year ago

N1ckP3rsl3y commented 1 year ago
dschlaep commented 1 year ago

Changed base of this PR to release/devel_v6.0.1

because updating rSOILWAT2 to be compatible with SOILWAT2 v7.1.0 (thread-safety and reentrancy) will not affect the user interface and is expected to produce identical simulation output -> for rSOILWAT2, this is a patch and not a minor version increase

codecov[bot] commented 1 year ago

Codecov Report

Merging #234 (0b30e7f) into release/devel_v6.0.2 (d4f3a36) will increase coverage by 0.08%. The diff coverage is 83.58%.

:exclamation: Current head 0b30e7f differs from pull request most recent head f0d325f. Consider uploading reports for the commit f0d325f to get more accurate results

@@                   Coverage Diff                    @@
##           release/devel_v6.0.2     #234      +/-   ##
========================================================
+ Coverage                 58.61%   58.69%   +0.08%     
========================================================
  Files                        42       42              
  Lines                      8058     8074      +16     
========================================================
+ Hits                       4723     4739      +16     
  Misses                     3335     3335              
Files Changed Coverage Δ
R/Rsw.R 68.85% <ø> (ø)
src/rSW_VegEstab.c 46.01% <29.41%> (ø)
src/rSW_Model.c 73.01% <33.33%> (ø)
src/rSW_SoilWater.c 45.45% <50.00%> (ø)
src/rSW_Markov.c 35.22% <60.00%> (ø)
src/rSW_Carbon.c 96.00% <88.88%> (ø)
src/rSW_VegProd.c 99.80% <90.00%> (ø)
src/rSW_Site.c 97.73% <95.74%> (ø)
src/rSW_Output.c 97.54% <97.77%> (+0.12%) :arrow_up:
R/swWeatherGenerator.R 36.26% <100.00%> (-0.14%) :arrow_down:
... and 5 more
dschlaep commented 1 year ago

All but one checks are passing; "r-devel" (on ubuntu-latest) is failing because it currently cannot install the dependency package "terra"

Error : in method for ‘RGB<-’ with signature ‘x="SpatRaster"’: arguments (‘value’) after ‘...’ in the generic must appear in the method, in the same place at the end of the argument list Error: Error: unable to load R code in package ‘terra’