Dsek-LTH / dsekdocs

A new LaTeX package for the styling of the D-guilds documents.
MIT License
1 stars 2 forks source link

Let signatures take an image representing the actual signature #17

Closed fnurkla closed 10 months ago

fnurkla commented 1 year ago

This is a work in progress as it gives ugly results when the signature is too wide.

fnurkla commented 10 months ago

Results are now much better: image but there are misalignments when the message above the signature has descenders: image

fnurkla commented 10 months ago

Alignments seem to be solved now: image

fnurkla commented 10 months ago

Do you have any input, @alfredgrip? Otherwise I'll be merging this.

alfredgrip commented 10 months ago

This looks really neat! However, I noticed that when there are multiple signatures (like 5+) and they break line, there is barely and margin between the one above and the one below. Would be nice to have.

Screenshot 2023-12-29 at 13 35 27

Edit: noticed that this only occurs when the LaTeX is written like

\signature[signfile=signature.png]{För D-sektionen, dag som ovan}{Alfred Grip}{\LaTeX -fantast}
\signature{För D-sektionen}{VA. Kant}{Okänd}
\signature{För D-sektionen}{VA. Kant}{Okänd}
\signature[signfile=signature.png]{För D-sektionen}{Alfred Grip}{\LaTeX -fantast}
\signature{För D-sektionen}{VA. Kant}{Okänd}

Manually breaking the line like

\signature[signfile=signature.png]{För D-sektionen, dag som ovan}{Alfred Grip}{\LaTeX -fantast}
\signature{För D-sektionen}{VA. Kant}{Okänd}
\signature{För D-sektionen}{VA. Kant}{Okänd}

\signature[signfile=signature.png]{För D-sektionen}{Alfred Grip}{\LaTeX -fantast}
\signature{För D-sektionen}{VA. Kant}{Okänd}

does include a margin between top and bottom. Maybe we should still allow users to write like the first example and still get nice formatting, thoughts?

fnurkla commented 10 months ago

Good catch. I'll see what I can do.

fnurkla commented 10 months ago

Added a small space now: image

alfredgrip commented 10 months ago

LGTM!