Allow control of pagination

[GoogleCodeExporter]

It would be nice if the level of pagination could be controlled either in
settings, as a view parameter or on a per user basis. Each method has it's
advantages and disadvantages.

Before I patch the code, I'd be interested in what method would be preferable?

Original issue reported on code.google.com by lu...@die.net.au on 4 Mar 2009 at 9:01

[GoogleCodeExporter]

Sorry, this should be changed to an Enhancement, not a Defect.

Original comment by lu...@die.net.au on 4 Mar 2009 at 9:02

[GoogleCodeExporter]

I don't really see the benefit of making this a per-user option. How about 
making it
a setting with a sensitble default? This means they can change the pagination 
setup
without touching the code. If we did it in urls.py, the user would have to 
change
code to change the setting.

Thoughts?

Original comment by rwpoul...@gmail.com on 8 Mar 2009 at 6:24

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

I agree. What I have done for now is use settings.FORUM_PAGINATION and replaced 
the
hard coded values in the forum views. I could send a patch if you like, but 
it's a
fairly trivial change set.

Original comment by lu...@die.net.au on 8 Mar 2009 at 7:00

[GoogleCodeExporter]

If you could send a patch it'd make life much easier :)  If you don't get one 
through
in the next few days I'll whip something up.

Original comment by rwpoul...@gmail.com on 9 Mar 2009 at 12:35

• Changed state: Started

[GoogleCodeExporter]

Here it is.

Original comment by lu...@die.net.au on 9 Mar 2009 at 12:54

Attachments:

• pagination.diff

[GoogleCodeExporter]

Thanks for that; added in SVN r40.

Original comment by rwpoul...@gmail.com on 9 Mar 2009 at 3:24

• Changed state: Fixed