Avoid indirect calls and enforce strict & warnings

[atoomic]

This work was performed on the p7 experimental branch and most of the changes comes from kid51.

[jkeenan]

This is failing tests on early perls due to the warnings issue that I commented on

Would something like this work (modulo line breaks)?

diff --git a/dist/Devel-PPPort/parts/inc/ppphtest b/dist/Devel-PPPort/parts/inc/ppphtest
index c6877afcbe..4a8b617cb2 100644
--- a/dist/Devel-PPPort/parts/inc/ppphtest
+++ b/dist/Devel-PPPort/parts/inc/ppphtest
@@ -681,7 +681,7 @@ my $fail = 0;
 for (@o) {
   my($name, $flags) = /^(\w+)(?:\s+\[(\w+(?:,\s+\w+)*)\])?$/ or $fail++;
   {
-    no warnings 'uninitialized';
+    BEGIN { 'warnings'->unimport('uninitialized') if "$]" > '5.006' }
     exists $p{$name} and $fail++;
     $p{$name} = defined $flags ? { map { ($_ => 1) } $flags =~ /(\w+)/g } : '';
   }

[khwilliamson]

On 7/19/20 12:09 PM, James E Keenan wrote:

This is failing tests on early perls due to the warnings issue that
I commented on

Would something like this work (modulo line breaks)?

|diff --git a/dist/Devel-PPPort/parts/inc/ppphtest b/dist/Devel-PPPort/parts/inc/ppphtest index c6877afcbe..4a8b617cb2 100644 --- a/dist/Devel-PPPort/parts/inc/ppphtest +++ b/dist/Devel-PPPort/parts/inc/ppphtest @@ -681,7 +681,7 @@ my $fail = 0; for (@o) { my($name, $flags) = /^(\w+)(?:\s+[(\w+(?:,\s+\w+)*)])?$/ or $fail++; { - no warnings 'uninitialized'; + BEGIN { 'warnings'->unimport('uninitialized') if "$]" > '5.006' } exists $p{$name} and $fail++; $p{$name} = defined $flags ? { map { ($_ => 1) } $flags =~ /(\w+)/g } : ''; } |

I need to regenerate D:P anyway, so I'll see what works:

[khwilliamson]

I tested this line successfully

'warnings'->unimport('uninitialized') if "$]" > '5.006';

[atoomic]

@khwilliamson with the last state at 68385410 this should fix 5.6

[atoomic]

@khwilliamson as discussed I've removed the extra unimport warnings BEGIN { 'warnings'->unimport('uninitialized') if "$]" > '5.006' } 8b9ff6d9 ready for another review