search

Dual-Life / Devel-PPPort

Perl/Pollution/Portability
9 stars 28 forks source link

Define PERL_ARGS_ASSERT_CROAK_XS_USAGE when setting croak_xs_usage #196

Closed atoomic closed 4 years ago

atoomic commented 4 years ago

This is matching what's done in ExtUtils::ParseXS::Utilities and avoids to redefine croak_xs_usage later.

References: #194

pali commented 4 years ago

See @khwilliamson commit 1ab5654ed0b3cf05335c7a3cf679a6b762c634ad which you are basically reverting by this PR.

atoomic commented 4 years ago

Indeed this mostly reverted 1ab5654ed0b3cf05335c7a3cf679a6b762c634ad which introduced this new warning I'm not sure it was fixing something? @khwilliamson can you confirm? At this point I still think this is the right thing to do

khwilliamson commented 4 years ago

The only reason I made that commit was because, as the message said, they were using a non-API element.

Now, it may be that was needed because we don't use variadic macros, so the function must be specified using the Perl_ prefix, and this is a way around that. I haven't investigated. But if that is the case that should have clearly been spelled out.

atoomic commented 4 years ago

@khwilliamson any objections in merging this change?