Dual-Life / Devel-PPPort

Perl/Pollution/Portability
9 stars 28 forks source link

Request: new release #212

Closed skaji closed 2 years ago

skaji commented 2 years ago

Currently clang 12+ emits a lot of -Wcompound-token-split-by-macro warnings with Devel-PPPort-3.63:

cc -Ixs-src -I/Users/skaji/env/plenv/versions/5.34.0/lib/perl5/5.34.0/darwin-2level/CORE -Wall -W -Wno-comment -c -fno-common -DPERL_DARWIN -mmacosx-version-min=12.1 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV -Wno-error=implicit-function-declaration -O3 -g -o xs-src/MouseAccessor.o xs-src/MouseAccessor.c
xs-src/MouseAccessor.xs:33:5: warning: '(' and '{' tokens introducing statement expression appear in different macro expansion contexts [-Wcompound-token-split-by-macro]
    CHECK_INSTANCE(instance);
    ^~~~~~~~~~~~~~~~~~~~~~~~
xs-src/MouseAccessor.xs:3:34: note: expanded from macro 'CHECK_INSTANCE'
#define CHECK_INSTANCE(instance) STMT_START{                           \
                                 ^~~~~~~~~~
xs-src/ppport.h:12400:31: note: expanded from macro 'STMT_START'
#  define STMT_START    (void)( /* gcc supports ``({ STATEMENTS; })'' */
                              ^

This has been fixed in blead Devel-PPPort at commit 8a0214ab98b.

Could you make a new release that includes this fix?

atoomic commented 2 years ago

thanks will reconciliation with blead and perform a release

atoomic commented 2 years ago

https://github.com/Dual-Life/Devel-PPPort/pull/213 is providing the missing commit

skaji commented 2 years ago

@atoomic Thanks! #213 looks good to me.

atoomic commented 2 years ago

v3.64 is now released and should fix the issue you were seeing thanks

skaji commented 2 years ago

@atoomic Thanks!