search

Dual-Life / Time-Piece

Object Oriented time objects
Other
15 stars 33 forks source link

Test coverage improvements #28

Closed openstrike closed 7 years ago

openstrike commented 8 years ago

In response to issue #26 this PR increases the coverage generally (all perl subs are now covered, even parse()) and also includes a number of tests of strptime for both regression and also TODO tests for these bugs:

There's also one TODO test for what I believe is a bug in that the strftime output with %s (to give epoch time) appears to be timezone dependent.

Note that some of the new tests generate "garbage at end of string in strptime" warnings which might indicate further issues with strptime.

This PR is submitted as part of the CPAN PR Challenge.

smith153 commented 7 years ago

Merged! Thanks for spending time on this :)

Noticed the %s tests with strptime() weren't passing. Looks like it doesn't handle GMT at all, I'll have to fix that. I will probably move most of the strptime() tests (and any other tricky ones) into an xt/ directory soon and then make sure they only run on demand or when going through cpantesters.