search

Dual-Life / Time-Piece

Object Oriented time objects
Other
15 stars 33 forks source link

remove unused strings from binary #8

Closed bulk88 closed 9 years ago

bulk88 commented 9 years ago

On VC2003/win32, these 2 strings were stored in RW memory in the shared library. They are unused/unreferenced in Time::Piece. Remove them to make the shared library binary smaller.

smith153 commented 9 years ago

I can merge, but why are we adding a define for NOID?

bulk88 commented 9 years ago

So that vars copyright and sccsid are compiled out but still remain in source code. Since the strptime code isn't a normal FOSS license, I am not sure we can outright delete those 2 vars from the src code. If you think we can, feel free to delete them. The 2 vars and their data are unused by Time::Piece, and waste space in the final shared library.

The vars might be related to http://en.wikipedia.org/wiki/Source_Code_Control_System .

smith153 commented 9 years ago

Re-licensing per https://www.illumos.org/issues/357 and http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libc/port/locale/strptime.c