line 698 condition not capturing data size

DublinLearningGroup / dataexpks

This package creates a kickstart rmarkdown document that automatically performs some basic data exploration for the supplied dataset.

MIT License

3 stars 2 forks source link

line 698 condition not capturing data size #7

Closed GRoughsedge closed 7 years ago

GRoughsedge commented 7 years ago

if(nrow(data_tbl) > mds_sample_count) { needs to be extended to be if(nrow(data_tbl %>% filter(row_ids)) > mds_sample_count) {

GRoughsedge commented 7 years ago

This also applies to line 763, it is: if(nrow(data_tbl) > tsne_sample_count) { and it should be: if(nrow(data_tbl) %>% filter(row_ids) > tsne_sample_count) {

kaybenleroll commented 7 years ago

Fixed this issue in a previous commit.