Duck-Tech-Dev / api-winnerduck

GNU General Public License v3.0
2 stars 0 forks source link

Request limit using the throttler package #19

Closed HuseyinSimsek7904 closed 7 months ago

HuseyinSimsek7904 commented 7 months ago

Closes #18

Explanation of the contents of the PR

The throttler package which the docs recommend can be used to limit the requests that the users can send. Using it is quite straightforward and requires no explanation.

Notes

erthium commented 7 months ago

I believe you might have used npm for package manager instead of yarn, which would explaing the huge change in yarn.lock, I think it's better to change it back to be consistent in package management and continue everything with yarn :)

I think you can easily rebase and go back, add the package you need again with yarn and commit the new yarn.lock file

erthium commented 7 months ago

Other than that, package looks fine as it was described in the NestJS Docs

They also use npm i --save <package> in the docs, you can just use yarn add <package>, which is kinda explained in this cheatsheet

HuseyinSimsek7904 commented 7 months ago

@ErtyumPX K, fixed that mistake.

HuseyinSimsek7904 commented 7 months ago

Alright, merging now...