DuckHunt-discord / DHV3

Obsolete version of the DuckHunt discord bot. Please see DHV4 instead. https://github.com/DuckHunt-discord/DHV4
https://github.com/DuckHunt-discord/DHV4
GNU Affero General Public License v3.0
44 stars 20 forks source link

Create duckspeak.py #47

Closed Turtle1331 closed 6 years ago

Turtle1331 commented 6 years ago

This module allows for quick and easy translation, primarily intended for French and English.

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Diagamma commented 6 years ago

Thanks, but even though DeepL is good, l10n is already implemented in the bot, and we prefer (well, I do) to have human-translated text than machine-translated text. Using this piece of code would also require adding more dependencies, and would add a huge latency, which is not very desirable. I had already thought about using DeepL for untranslated strings, but I don't think it's worth all the trouble, latency and stuff. IMO, this is not a good idea, so I'm vetoing this PR. I'm not closing it though, since @paris-ci is the owner and it would be disrespectful of me to do it without letting him give his opinion.

Turtle1331 commented 6 years ago

Thanks for the clear response. I understand the issue with adding dependencies. I don't get what you mean by the human-translation over machine-translation part though. Could there still be some possibility of adding it to the server as one of the external bots? Thank you for considering my request.

paris-ci commented 6 years ago

@Diagamma misunderstood the commit. Just to clarify, it is not intended as a replacement of lingohub translation; but as a new command for DuckHunt Community, for people who want to understand french said in #general on the DuckHunt server.

He didn't understood because you put your cog in cogs/duckspeak.py and you should have put in on community/cogs/duckspeak.py (I agree that's not clear, and I'm soon gonna move the CommunityBot in it's own repo)

@Turtle1331 Could you please just move the file to community/cogs/duckspeak.py ?

Thanks,

Arthur

Diagamma commented 6 years ago

Oh right, I'm stupid. That's what I get for reviewing at 2AM. Seems like a good idea then. Sorry. @paris-ci Yeah, please move it to its own repo. :P

Turtle1331 commented 6 years ago

Ok, that latest commit should have fixed it. Thanks @paris-ci for the clarification.