DuckWillow / pe

0 stars 0 forks source link

More accepted input for <day> argument #15

Open DuckWillow opened 3 years ago

DuckWillow commented 3 years ago

image.png

The accepted input for the argument includes “Monday”, “Tuesday”, “Wednesday”, “Thursday”, “Friday”, “Saturday”, and “Sunday”.

However, during testing, "monday" is also accepted.

nus-pe-bot commented 2 years ago

Team's Response

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Uppercase and lowercase are not case sensitive

At beginning, I found this when key in weekdays.

image.png

Only 'Friday' or 'friday' should be allowed in the schedule. Keep the format the same!

image.png

The same problem happens in the timetable function.

Then I realize all uppercase and lowercase is mixed up together.

image.png

image.png


[original: nus-cs2113-AY2122S1/pe-interim#7] [original labels: type.FeatureFlaw severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your report.

For the day case sensitive part, it is by design. It is mentioned in the UG under the section Command Syntax.

image.png

For the command case sensitive part, it is also by design and mentioned in the UG under the section Command Syntax.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team has force every module to be uppercase: cs2113T to CS2113T.

They should do the same from 'friday' to 'Friday'.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.DocumentationBug]

Reason for disagreement: Not consistent throughout the program. Users don't want to see 'friday' and 'Friday' appear at the same time. And it's not hard to make a replacement.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is important because it improve user experience. Users don't want to see 'friday' and 'Friday' appear at the same time.