search

DuckWillow / pe

0 stars 0 forks source link

Wrong time is accepted for schdule function #16

Open DuckWillow opened 3 years ago

DuckWillow commented 3 years ago

image.png

Time 24:00 should be rejected.

nus-pe-script commented 2 years ago

Team's Response

Thank you for your report.

24:00 is still a valid time, to some it is considered as 00:00. For more information please refer to: https://en.wikipedia.org/wiki/24-hour_clock#Midnight_00:00_and_24:00

In addition, for this specific issue, it will also be rejected as it was tested during the Part 2.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From the Wikipedia:

The notation 24:00 mainly serves to refer to the exact end of a day in a time interval. Typical usage is giving opening hours ending at midnight (e.g. "00:00–24:00", "07:00–24:00").

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Adding this exception is not very hard. The team refused to admit their mistake.