DuckWillow / pe

0 stars 0 forks source link

Lack of restriction for the module code #4

Open DuckWillow opened 3 years ago

DuckWillow commented 3 years ago

image.png

image.png

image.png

There should be at least some restriction for the module input. A single char 'C' or ',' can never be a real module code. Don't code as if it's just a project, code as if it's your company product and you will serve the real people.

soc-pe-bot commented 2 years ago

Team's Response

This is by design to not check whether the module code is valid.

The only concern in the module code is the saving to directory part where it could pose some issues due to file system name restriction.

We want to give user the freedom of choice to pick whatever module name they want as such it is not intended by design to ensure that it is a valid module name.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]