search

DuckyCrayfish / hourglass

Hourglass is a Minecraft Forge mod that gives you control over the passage of time. It allows you to customize the length of the day-night cycle and alters the Minecraft sleep mechanic by accelerating the speed of time.
GNU Lesser General Public License v3.0
14 stars 4 forks source link

Better unit for scaling time? #52

Open johalun opened 1 year ago

johalun commented 1 year ago

First off, thanks for making this mod. It's a great addition to Minecraft!

However, one thing that I think is a bit unfortunate is how we speed up / slow down time through the config file. Currently a value of 1.0 means default Minecraft time, 2.0 means time in Minecraft progresses twice as fast.

For me the use of this mod would only be to slow down the time in Minecraft and in order to match Minecraft time with real time I have slow it down by a factor of 72. To do this in the config that means we have to set a irrational decimal value (0.013888.....) and we'll end up with an increasing time drift as time goes on.

I think a better way would be to be able to specify how many ticks a day should be, unless there are any unknown factors preventing this that I'm no aware of.

Thanks!

Sixdd6 commented 1 year ago

Highly agree with this, I use Time Control on other versions of minecraft which allows to set specific minute values for day and night length. This allows for much easier configuration and doesn't have the negative of having to calculate a strange decimal value.

SaltSouls commented 1 year ago

First off, thanks for making this mod. It's a great addition to Minecraft!

However, one thing that I think is a bit unfortunate is how we speed up / slow down time through the config file. Currently a value of 1.0 means default Minecraft time, 2.0 means time in Minecraft progresses twice as fast.

For me the use of this mod would only be to slow down the time in Minecraft and in order to match Minecraft time with real time I have slow it down by a factor of 72. To do this in the config that means we have to set a irrational decimal value (0.013888.....) and we'll end up with an increasing time drift as time goes on.

I think a better way would be to be able to specify how many ticks a day should be, unless there are any unknown factors preventing this that I'm no aware of.

Thanks!

Hey there, not the mod dev here, but I think I can answer this one. The issue with changing the amount of ticks really boils down to compatibility reasons. If hourglass were to allow you to directly change the actual amount of time in an MC day, it could end up causing issues for other mods that rely on certain time periods and are checking this using the getDayTime() function. Most of the time, unless maybe a better method can be used(I don't know of one), these devs are making direct checks based on the normal length of time in a MC day. Currently as it stands, Hourglass allows the user to adjust the progression of time without directly touching these numbers, thus making it inherently compatible with any and all mods that rely on the normal day length.

With all that being said, There may be a way to do this while still being compatible with other mods, but I imagine it will be way more trouble than it's worth and potentially lead to way more problems in the future. So while possible(maybe), I really don't think this is a change that should be made, especially not for the sole reason of matching to real time. I think there are already mods out there that do this. Though because of how they would likely have to touch the length of time, they are probably not going to be compatible with not only hourglass, but other mods that use time related functions in them as well.

Hope this helps explain things at least a little bit.