Dude-Perfect-Discord-Bot / Dude-Perfect

Dude Perfect is a bot that can do most of the things that everything you require for making a better and better Discord Server.
https://discord.gg/ZzbZpdw
Apache License 2.0
4 stars 14 forks source link

chore: update Top.gg dependency #107

Closed officialpiyush closed 3 years ago

officialpiyush commented 3 years ago

Details

Checklist

Note: We will close your PR without comment if you do not check the boxes above and provide ALL requested information.

officialpiyush commented 3 years ago

Would like some opinions, I think we shouldn't log after every successful post, all it's gonna do is spam the console.

anishshobithps commented 3 years ago

Would like some opinions, I think we shouldn't log after every successful post, all it's gonna do is spam the console.

only if there is a error then send the error , I don't think so there is any requirement in logging each time it posts the data.

officialpiyush commented 3 years ago

only if there is a error then send the error , I don't think so there is any requirement in logging each time it posts the data.

The library doesn't provide any event about the failed post(s), I've created a PR to the repo https://github.com/jpbberry/topgg-autoposter/pull/4. Imma restore the error event file.

XynoxTheDev commented 3 years ago

Yes! Logging of errors has a point but every event of the Autopost is not to be recorded. It will only result in beautiful spam which we and our console don't want. If it's possible then only we should implement this update else we should discontinue using the top.gg integration.

officialpiyush commented 3 years ago

ding dong, review time