Closed officialpiyush closed 3 years ago
Would like some opinions, I think we shouldn't log after every successful post, all it's gonna do is spam the console.
Would like some opinions, I think we shouldn't log after every successful post, all it's gonna do is spam the console.
only if there is a error then send the error , I don't think so there is any requirement in logging each time it posts the data.
only if there is a error then send the error , I don't think so there is any requirement in logging each time it posts the data.
The library doesn't provide any event about the failed post(s), I've created a PR to the repo https://github.com/jpbberry/topgg-autoposter/pull/4. Imma restore the error event file.
Yes! Logging of errors has a point but every event of the Autopost is not to be recorded. It will only result in beautiful spam which we and our console don't want. If it's possible then only we should implement this update else we should discontinue using the top.gg integration.
ding dong, review time
Details
Checklist