No error when inserting a Version Number <4

DudeNr33 / pyinstaller-versionfile

Create a windows versionfile from a simple YAML file that can be used by PyInstaller.

MIT License

40 stars 5 forks source link

No error when inserting a Version Number <4 #4

Closed DruideBizeps closed 3 years ago

DruideBizeps commented 3 years ago

When a version number with less than 4 point separated digits is used no error is reported, but the pyinstaller fails because of that. Proposal: Either warn the user, or fill up the missing places with 0(s)

DudeNr33 commented 3 years ago

Thank you for reporting this. I agree, pyinstaller-versionfile should try to only create output which can be interpreted by PyInstaller. Since version numbers with less than 4 places are very common I will go for your second suggestion and fill it up with zeros.

DudeNr33 commented 3 years ago

Fixed with v1.0.2.