Dudemanguy / mpv-manga-reader

Manga reading script for mpv
GNU General Public License v3.0
120 stars 4 forks source link

keybinds clash #18

Closed NormTurtle closed 1 year ago

NormTurtle commented 1 year ago

the key m lower is bound to mute and also in for reader at input.conf i made it bound m script-message toggle-manga-mode

but its not working coz mpv think m = mute , not manga mode

solution: -give proper way to achive only image based keybinds? mute is useless for images

Dudemanguy commented 1 year ago

This works for me. So does adding a binding in input.conf. Are you sure you actually started the manga reader?

NormTurtle commented 1 year ago

yes manga reader is started even i set it to audo_start=yes but still mpv catches m as mute not magamode

Dudemanguy commented 1 year ago

I'm am fairly certain that add_key_binding will always override the default bindings. Even if it didn't, setting it in your input.conf should work anyways. Are you absolutely positive you don't have some other rogue script or something that sets this?

What happens if you try it with something like mpv --no-config --script=/path/to/manga-reader.lua --log-file=mpv.lgo manga.zip? Also please post that log file.

NormTurtle commented 1 year ago

mpv --no-config --script=./manga-reader.lua --log-file=manga.log .\Naruto\ manga.log

yes in vanila , it overwrite the default keys , worked well

some question: image why is this occuring? only when i include manga reader

when not including* --script=./manga-reader.lua image

when including --script=./manga-reader.lua image

this occurred immediately when i pressed y

Dudemanguy commented 1 year ago

yes in vanila , it overwrite the default keys , worked well

In that case, you must have some other script or something that is interfering with it.

why is this occuring? only when i include manga reader

That's just a harmless warning. The manga reader writes to the playlist-pos property which can cause that. I can probably just change it to playlist-play-index since that property has been around for a while and should do the same thing.

Edit: Just updated that.

NormTurtle commented 1 year ago

first of all , everything is worked expect ~something the new commit fixed the playlist-pos good this is was needed some workaround for getting in work in ~ my config in profiles.conf added [image] -profile-cond=vid and not p["current-tracks/video/albumart"] and estimated_frame_count <= 1

this din't worked too :( i have to explicitly put auto_start=yes so it worked ! but key y is not showing anythign anymore?

can you tell why is that happening? my mpv.conf has no-input-default-bindings which block some of inbuild keys my input.conf for reference to reader

## MANGA READER 
y script-message toggle-manga-reader
d script-message toggle-double-page
c script-message toggle-continuous-mode 
M script-message toggle-manga-mode 
l script-message next-page
h script-message prev-page 
Shift+l script-message next-single-page 
Shift+h script-message prev-single-page
Ctrl+l script-message skip-forward
Ctrl+RIGHT script-message skip-backward
HOME script-message first-page
END script-message last-page
k script-message pan-up 
j script-message pan-down
/ script-message jump-page-mode
ENTER script-message jump-page-go
ctrl+[ script-message jump-page-quit

some scripts i found to interfaring with .cbz quality-menu.conf,`

wats the difference between toggle-manga-mode: m & toggle-manga-reader: y exactly? please update readme with that too

Dudemanguy commented 1 year ago

toggle-manga-reader is what actually starts the script. It doesn't do anything unless you turn it on (auto_start makes it always turn on). toggle-manga-mode just switches from right-to-left to left-to-right. It's completely different.

In theory you shouldn't need the autoprofile workaround, so I'm not sure what is happening there.

NormTurtle commented 1 year ago

im closing as my brain cells start to looss i dont knwo how to fix without autoprofiling :(