search

Dudemanguy / mpv-manga-reader

Manga reading script for mpv
GNU General Public License v3.0
119 stars 4 forks source link

double page: error #19

Closed zaeboba closed 1 year ago

zaeboba commented 1 year ago

after turning on a double page, after a couple of pages this error appears and the player does not respond to any buttons (no it does not freeze, it's like reading manga and then accidentally press again "y") mpv_22 46 35

Dudemanguy commented 1 year ago

Could you upload a sample where this happens?

zaeboba commented 1 year ago

Upload the manga? it weighs 1 gigabyte

Dudemanguy commented 1 year ago

I don't need the whole thing. Just the small set of pages where this error happens would work.

zaeboba commented 1 year ago

it does not occur on the same

Dudemanguy commented 1 year ago

That's a bit unfortunate. There's no way to make a small subset where the error happens? If not, I guess downloading the whole thing is fine. I don't mind; I just need to be able to reproduce this to see what exactly is happening.

zaeboba commented 1 year ago

For example, the error appeared at once, only the browsing continued to work. In your case, after entering read mode and watching manga, if you press "y" again, what happens? I, for example, mpv does not respond to any hotkeys, only closing the player and opening again.

Try pressing hotkeys, I use these "home", "ctrl - right/left", "shift - right/left" without entering manga reading mode (m).

https://transfer.sh/GGy9zK/Tke5edqG32.mp4 - error demonstration video

https://drive.google.com/file/d/1vPEDiURd-1UMjilo7lgDtzpgcln4hnO2/view?usp=sharing - manga.

I don't know, maybe it's because it weighs a lot? I'm afraid to imagine what will happen to "berserk" which has three times the weight. Note the state of the player in the bar (demonstration video)

Dudemanguy commented 1 year ago

Thanks, I see the problem. It's attempting to perform a double page when it clearly shouldn't. The calculation works when going forward but not backwards for some reason. I'll try to find some time to look into this.

Dudemanguy commented 1 year ago

It's admittedly not perfect but should be usable now.

Edit: I came up with a hack that should fix this hopefully.