search

Dudemanguy / mpv-manga-reader

Manga reading script for mpv
GNU General Public License v3.0
119 stars 4 forks source link

[PR-ish] some suggestions #5

Closed NightMachinery closed 3 years ago

NightMachinery commented 3 years ago

I find these options useful:

function mpv-manga() {
   mpv --no-config --load-scripts=no --script=~/.config/mpv/mpv-manga-reader/manga-reader.lua --image-display-duration=inf --input-conf=~/.config/mpv/input.conf --reset-on-next-file=video-pan-x,video-pan-y --video-align-x=1 --video-align-y=-1 --video-zoom=1 --fs --glsl-shaders="~~/shaders/Anime4K_3.0_Denoise_Bilateral_Mode.glsl:~~/shaders/Anime4K_3.0_Upscale_CNN_M_x2_Deblur.glsl" "$@"
}

Especially the https://github.com/bloc97/Anime4K shaders are game-changing.

I also made some changes here.

I have some good hotkeys for zooming, panning, and switching glsl shaders in my input.conf.

PS: Perhaps I should just add this post to the wiki?

Dudemanguy commented 3 years ago

Seems like very opinionated changes to me. Well for the keybinding/option stuff, you can always just set in your conf/input files (no need to hardcode those). The zoom-related things I have no strong opinion on however so maybe those can be changed and/or exposed as options.

Dudemanguy commented 3 years ago

All this stuff should be configurable now (finally added a zoom_multiplier option for continuous mode). Closing this now.